Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open editor for translated content #3196

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

fiji-flo
Copy link
Contributor

No description provided.

@fiji-flo fiji-flo requested a review from peterbe March 11, 2021 07:14
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-03-11 at 1 05 43 PM

I don't know what in the code is wrong but it's not working in en-US docs.

@peterbe
Copy link
Contributor

peterbe commented Mar 11, 2021

It's a bummer that we have no end-to-end tests for the "Open in your editor".
I guess we could mock a binary that all it does is logging what it was opened with.

@peterbe
Copy link
Contributor

peterbe commented Mar 11, 2021

@fiji-flo
Copy link
Contributor Author

Weird. I'm sure I tested it and it should have never worked I guess 😕

Good catch.

@fiji-flo fiji-flo requested a review from peterbe March 11, 2021 18:55
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

@peterbe peterbe merged commit c3f07a0 into mdn:main Mar 11, 2021
wbamberg pushed a commit to wbamberg/yari that referenced this pull request Mar 15, 2021
* upstream/main: (164 commits)
  skip empty srcs for safe iframe srcs (mdn#3216)
  correct code comment (mdn#3223)
  build(deps): bump ahmadnassri/action-dependabot-auto-merge (mdn#3197)
  build(deps-dev): bump @types/react-dom from 17.0.1 to 17.0.2 (mdn#3164)
  create a whatsdeployed.json for translated-content too (mdn#3221)
  avoid double-slash redirects (mdn#3222)
  build(deps): bump image-size from 0.9.4 to 0.9.5 (mdn#3214)
  build(deps): bump boto3 from 1.17.22 to 1.17.26 in /deployer (mdn#3212)
  Fix our auto-merge workflow (mdn#3218)
  build(deps-dev): bump ts-loader from 8.0.17 to 8.0.18 (mdn#3208)
  disable lighthouse PR check unless relevant changes (mdn#3203)
  hide toolbar for frozen locales (mdn#3213)
  build(deps): bump is-svg from 4.2.1 to 4.2.2 (mdn#3209)
  build(deps): bump @mdn/browser-compat-data from 3.1.3 to 3.2.0 (mdn#3210)
  downloading external images for translated-content (mdn#3207)
  add active locales (mdn#3201)
  add tool command for rendering/removing macros (mdn#2955)
  unsafe html should be a breaking flaw (mdn#3192)
  open editor for translated content (mdn#3196)
  add fundamental redirects for /en-US/Security/CSP (mdn#3200)
  ...
peterbe pushed a commit to peterbe/yari that referenced this pull request Jun 1, 2021
* open editor for translated content

* fix parsing locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants