-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fundamental redirects for /en-US/Security/CSP #3200
add fundamental redirects for /en-US/Security/CSP #3200
Conversation
Co-authored-by: Ryan Johnson <escattone@gmail.com>
This is why PR review is so important! Sorry. I must have rushed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbe I forgot one thing. Let's add this to the integration tests as well, so add:
url_test("/en-US/Security", "/en-US/docs/Security"),
url_test("/en-US/Security/", "/en-US/docs/Security"),
url_test("/en-US/Security/CSP/", "/en-US/docs/Security/CSP"),
immediately after this line:
yari/testing/integration/headless/map_301.py
Line 1037 in 671cbc0
url_test("/en-US/XMLHttpRequest/FormData/", "/en-US/docs/XMLHttpRequest/FormData"), |
and we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterbe!
* upstream/main: (164 commits) skip empty srcs for safe iframe srcs (mdn#3216) correct code comment (mdn#3223) build(deps): bump ahmadnassri/action-dependabot-auto-merge (mdn#3197) build(deps-dev): bump @types/react-dom from 17.0.1 to 17.0.2 (mdn#3164) create a whatsdeployed.json for translated-content too (mdn#3221) avoid double-slash redirects (mdn#3222) build(deps): bump image-size from 0.9.4 to 0.9.5 (mdn#3214) build(deps): bump boto3 from 1.17.22 to 1.17.26 in /deployer (mdn#3212) Fix our auto-merge workflow (mdn#3218) build(deps-dev): bump ts-loader from 8.0.17 to 8.0.18 (mdn#3208) disable lighthouse PR check unless relevant changes (mdn#3203) hide toolbar for frozen locales (mdn#3213) build(deps): bump is-svg from 4.2.1 to 4.2.2 (mdn#3209) build(deps): bump @mdn/browser-compat-data from 3.1.3 to 3.2.0 (mdn#3210) downloading external images for translated-content (mdn#3207) add active locales (mdn#3201) add tool command for rendering/removing macros (mdn#2955) unsafe html should be a breaking flaw (mdn#3192) open editor for translated content (mdn#3196) add fundamental redirects for /en-US/Security/CSP (mdn#3200) ...
* add fundamental redirects for /en-US/Security/CSP Fixes mdn#3199 * Update libs/fundamental-redirects/index.js Co-authored-by: Ryan Johnson <escattone@gmail.com> * feedbacked Co-authored-by: Ryan Johnson <escattone@gmail.com>
Fixes #3199
I didn't test it but it looks sufficiently safe.