Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat BCD ranges as exact versions to avoid confusion for the reader #3494

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 12, 2021

Fixes #3238.

BCD has version ranges to signal that the exact support version is unknown still. This is useful for data maintenance and data improvements but displaying the "≤" hint to readers on MDN compat tables has lead to confusion and the tooltip we've provided didn't really help with that either (apparently). So, let's not expose this to readers at all.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaaaaaaay!

@peterbe peterbe requested a review from ddbeck April 13, 2021 14:02
@peterbe
Copy link
Contributor

peterbe commented Apr 13, 2021

@Elchi3 and @foolip are in agreement. I'm actually happy to merge this without fully understanding but I think I would sleep better at night if I knew @ddbeck could give his support and test it too.

@peterbe
Copy link
Contributor

peterbe commented Apr 13, 2021

@Elchi3 Do you want to change your PR comment to say "Fixes #3238" instead? Or is this PR just a part of resolving the issue?

@peterbe
Copy link
Contributor

peterbe commented Apr 13, 2021

What's some good pages to test this on?

@ddbeck
Copy link
Contributor

ddbeck commented Apr 13, 2021

What's some good pages to test this on?

https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D#browser_compatibility has a bunch of entries with version ranges

…ature-row.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this, for sure. 👍

@peterbe peterbe merged commit bc24a08 into mdn:main Apr 13, 2021
@Elchi3 Elchi3 deleted the ommit-bcd-ranges branch April 13, 2021 14:13
peterbe pushed a commit to peterbe/yari that referenced this pull request Jun 1, 2021
…dn#3494)

* Treat BCD ranges as exact versions to avoid confusion for the reader

* Update client/src/document/ingredients/browser-compatibility-table/feature-row.tsx

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>

Co-authored-by: Peter Bengtsson <peterbe@mozilla.com>
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat BCD ranges as exact versions, hiding "≤" annotation
5 participants