Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat BCD ranges as exact versions to avoid confusion for the reader #3494

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Treat BCD ranges as exact versions to avoid confusion for the reader #3494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1870927
Treat BCD ranges as exact versions to avoid confusion for the reader
Elchi3 Apr 12, 2021
f1bb058
Update client/src/document/ingredients/browser-compatibility-table/fe…
Elchi3 Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,11 @@ function labelFromString(version: string | boolean | null | undefined) {
if (typeof version !== "string") {
return <>{"?"}</>;
}
if (!version.startsWith("≤")) {
return <>{version}</>;
// Treat BCD ranges as exact versions to avoid confusion for the reader
Elchi3 marked this conversation as resolved.
Show resolved Hide resolved
if (version.startsWith("≤")) {
return <>{version.slice(1)}</>;
}
const title = `Supported in version ${version.slice(1)} or earlier.`;
return (
<span title={title}>
<sup>≤&#xA0;</sup>
{version.slice(1)}
</span>
);
return <>{version}</>;
}

const CellText = React.memo(
Expand Down