Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing Luxembourg bank #198

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update missing Luxembourg bank #198

merged 2 commits into from
Apr 30, 2024

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Apr 29, 2024

image

@Natim
Copy link
Contributor Author

Natim commented Apr 29, 2024

I search for scripts/get_bank_registry_lu.py without luck. @mdomke should we move it into manual_lu.json? Do you have a script for it?

@mdomke
Copy link
Owner

mdomke commented Apr 30, 2024

I think it was added in #111 and the author didn't want to upload his script, because it might have included some brute-forcing of other APIs. I think it would be the cleanest solution for now to rename the file to manual_lu.json.

@mdomke mdomke merged commit b87f209 into mdomke:main Apr 30, 2024
8 checks passed
@Natim Natim deleted the feat/missing-lu-bank branch April 30, 2024 14:19
mdomke added a commit that referenced this pull request May 9, 2024
@mdomke
Merge branch 'main' into feature/add-random-iban-generation
24f4b2c 
* main:
  chore: Add changelog for release 2024.05.2
  Install typing-extensions for Python <= 3.10
  chore: Add changelog for release 2024.05.1
  Revert "add pyinstaller support (#92)"
  Improve Pydantic support for BIC objects
  Remove the iso3166 library as we already have pycountry
  Use Self for more accurate typing (#201)
  Improve Pydantic support
  Update generated according to script spec (#199)
  Update missing Luxembourg bank (#198)
  Update IBAN registry spec (#197)
  chore: Update to GitHub actions setup-python@5
  Added manually curated bank registry for Montenegro
  Add CHANGELOG for 2024.04.0 release
@Natim Natim mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Natim @mdomke