add pyinstaller support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdomke
requested changes
May 29, 2022
This was referenced May 9, 2024
bwoodsend
reviewed
May 9, 2024
Comment on lines
+49
to
+52
| if getattr(sys, "frozen", False) and hasattr(sys, "_MEIPASS"): | ||
| package_path = Path(getattr(sys, "_MEIPASS")) | ||
| else: | ||
| package_path = files(__package__) |
There was a problem hiding this comment.
PyInstaller maintainer here: Wherever you got this code snippet from, can you please delete/downvote/mark it as invalid/expunge it from the internet. It is misinformation.
PyInstaller expects you to preserve package structure (i.e. these data files would go into $app_root/schwifty/bank_registry instead of $app_route/bank_registry). Without this change, a user could have used --collect-data=schwifty and everything would have worked out fine. With this change, the user has to force their JSON files into the wrong place.
mdomke
added a commit
that referenced
this pull request
May 9, 2024
* main: chore: Add changelog for release 2024.05.2 Install typing-extensions for Python <= 3.10 chore: Add changelog for release 2024.05.1 Revert "add pyinstaller support (#92)" Improve Pydantic support for BIC objects Remove the iso3166 library as we already have pycountry Use Self for more accurate typing (#201) Improve Pydantic support Update generated according to script spec (#199) Update missing Luxembourg bank (#198) Update IBAN registry spec (#197) chore: Update to GitHub actions setup-python@5 Added manually curated bank registry for Montenegro Add CHANGELOG for 2024.04.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pyinstaller.
When app with schwifty is compile to .exe there is a problem with path.
This change fix this problem.