fix: position could be null actually (#524)

mdx-js · Jan 14, 2024 · ee3b593 · ee3b593
1 parent 2da97b2
commit ee3b593
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/two-eagles-flash.md b/.changeset/two-eagles-flash.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-mdx": patch
+---
+
+fix: `position` could be `null` actually - related to #520
diff --git a/packages/eslint-plugin-mdx/src/rules/remark.ts b/packages/eslint-plugin-mdx/src/rules/remark.ts
@@ -72,7 +72,7 @@ export const remark: Rule.RuleModule = {
           fatal,
           line,
           column,
-          position: { start, end },
+          position,
         } of messages) {
           // https://github.com/remarkjs/remark-lint/issues/65#issuecomment-220800231
           /* istanbul ignore next */
@@ -83,6 +83,8 @@ export const remark: Rule.RuleModule = {
             continue
           }
 
+          const { start, end } = position || /* istanbul ignore next */ {}
+
           const message: RemarkLintMessage = {
             reason,
             source,
@@ -96,11 +98,11 @@ export const remark: Rule.RuleModule = {
               line,
               // ! eslint ast column is 0-indexed, but unified is 1-indexed
               column: column - 1,
-              start: {
+              start: start && {
                 ...start,
                 column: start.column - 1,
               },
-              end: {
+              end: end && {
                 ...end,
                 column: end.column - 1,
               },