Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position could be null actually #524

Merged
merged 3 commits into from
Jan 14, 2024
Merged

fix: position could be null actually #524

merged 3 commits into from
Jan 14, 2024

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 14, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

realted to #520

Copy link

changeset-bot bot commented Jan 14, 2024

🦋 Changeset detected

Latest commit: 53f1ebf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
eslint-plugin-mdx Patch
eslint-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jan 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2da97b2) 100.00% compared to head (53f1ebf) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-v2      #524   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              19        19           
  Lines             194       197    +3     
  Branches           32        35    +3     
============================================
+ Hits              194       197    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin merged commit ee3b593 into release-v2 Jan 14, 2024
20 checks passed
@JounQin JounQin deleted the fix/position branch January 14, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants