Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename module name #282

Merged
merged 6 commits into from
Mar 22, 2022
Merged

refactor: rename module name #282

merged 6 commits into from
Mar 22, 2022

Conversation

0xHansLee
Copy link
Contributor

I split this issue for convenience in review.

In this PR, I just renamed module name from market to datadeal.

@0xHansLee 0xHansLee added the Market Data Marketplace for Web3.0 label Mar 17, 2022
@0xHansLee 0xHansLee added this to the Data Pool Model milestone Mar 17, 2022
@0xHansLee 0xHansLee requested a review from cl9200 as a code owner March 17, 2022 02:09
@0xHansLee 0xHansLee self-assigned this Mar 17, 2022
gyuguen
gyuguen approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I left a few reviews.

app/app.go Outdated Show resolved Hide resolved
types/testsuite/suite.go Outdated Show resolved Hide resolved
gyuguen
gyuguen reviewed Mar 21, 2022
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@0xHansLee 0xHansLee linked an issue Mar 21, 2022 that may be closed by this pull request
Define the x/datapool skeleton + proto files #273
Closed
inchori
inchori approved these changes Mar 22, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

youngjoon-lee
youngjoon-lee approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xHansLee 0xHansLee merged commit ae0d892 into master Mar 22, 2022
@0xHansLee 0xHansLee deleted the ft/273/rename-module branch March 22, 2022 08:55
@youngjoon-lee youngjoon-lee mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@0xHansLee 0xHansLee

Labels
Market Data Marketplace for Web3.0
Projects
None yet
Milestone
Data Pool Model
Development

Successfully merging this pull request may close these issues.

Define the x/datapool skeleton + proto files
4 participants
@0xHansLee @youngjoon-lee @gyuguen @inchori