-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Register Data Validator Transaction #285
Conversation
proto/panacea/datapool/v2/pool.proto
Outdated
string endpoint = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just put a endpoint
field in DataValidator
message. Refer to this docs, the some fields can be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that the DataValidator should contain an address as well.
How about adding an address like this?
message DataValidator {
string address = 1;
string endpoint = 2;
}
Perhaps additional different values will be added during actual development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this might be better.
return []sdk.AccAddress{dataValidator} | ||
} | ||
|
||
var _ sdk.Msg = &MsgCreatePool{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I need to write test code, I implemented all of our transaction such as MsgCreatePool
, MsgSellData
, MsgBuyDataAccessNFT
in message_pool.go
.
proto/panacea/datapool/v2/pool.proto
Outdated
string endpoint = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that the DataValidator should contain an address as well.
How about adding an address like this?
message DataValidator {
string address = 1;
string endpoint = 2;
}
Perhaps additional different values will be added during actual development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
After merging this branch, I will rebase it for #275. Thanks!
Implement Register Data Validator Transaction
RegisterDataValidator
method inkeeper/pool.go
.DataValidator
message intx.proto
for store data validator.In next PR, I'll implement Cmd for Register Data Validator transaction.