Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix e2e tests post chrome update #8654

Merged
merged 3 commits into from
Oct 20, 2023
Merged

chore: fix e2e tests post chrome update #8654

merged 3 commits into from
Oct 20, 2023

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Oct 20, 2023 •
edited by garethbowen
Loading

Description

#8685

adds utils.url function that refreshes the page when the passed url is the same as the loaded page.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

jonathanvq
jonathanvq approved these changes Oct 20, 2023
View reviewed changes
Copy link

@jonathanvq jonathanvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dianabarsan dianabarsan merged commit 9c472f7 into master Oct 20, 2023
34 checks passed
@dianabarsan dianabarsan deleted the fix-e2e-tests branch October 20, 2023 16:47
Benmuiruri pushed a commit that referenced this pull request Oct 26, 2023
@dianabarsan @Benmuiruri
chore: fix e2e tests post chrome update (#8654)
956f81a
latin-panda pushed a commit that referenced this pull request Nov 8, 2023
@dianabarsan @latin-panda
chore: fix e2e tests post chrome update (#8654)
9d100be
latin-panda added a commit that referenced this pull request Nov 9, 2023
@latin-panda @dianabarsan
chore: fix e2e tests post chrome update (#8654) (#8688)
54cb3cf 
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
m5r pushed a commit that referenced this pull request Nov 20, 2023
@dianabarsan @m5r
chore: fix e2e tests post chrome update (#8654)
d4f3bb7
m5r pushed a commit that referenced this pull request Nov 20, 2023
@dianabarsan @m5r
chore: fix e2e tests post chrome update (#8654)
bbadd76
dianabarsan added a commit that referenced this pull request Dec 8, 2023
@dianabarsan
chore: fix e2e tests post chrome update (#8654)
ade7086 
(cherry picked from commit 9c472f7)
dianabarsan added a commit that referenced this pull request Dec 8, 2023
@dianabarsan
chore: fix e2e tests post chrome update (#8654) (#8749)
a79f4bb 
(cherry picked from commit 9c472f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanvq jonathanvq jonathanvq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianabarsan @jonathanvq