chore: backporting e2e fix #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorerod can you please check this small PR? It's a backport of a fix that will allow the unblocking of the CI for this Feature Release. Thanks for your time! |
5 tasks
lorerod
approved these changes
Nov 8, 2023
| await commonPage.goToReports(); | ||
|
|
||
| await browser.url('#/reports/add/pregnancy'); | ||
| await browser.url('/#/reports/add/pregnancy'); |
There was a problem hiding this comment.
Why we don't use here the new commonPage.goToUrl() method?
There was a problem hiding this comment.
That is a very good question. I'm not the original author, but it seems like commonPage.goToUrl() should work here.
Do you think we should encourage the usage of commonPage.goToUrl() always as a replacement for browser.url(..?
If yes, I can open a separate PR to do the replacement all over the e2e, so that's the way to go for other developers when writing tests.
There was a problem hiding this comment.
It is a great idea to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting 956f81a
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.