Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0: change the behavior of --schedule-snapshot #2079

Closed
2 tasks done
maryamsulemani97 opened this issue Jan 3, 2023 · 0 comments · Fixed by #2120
Closed
2 tasks done

v1.0: change the behavior of --schedule-snapshot #2079

maryamsulemani97 opened this issue Jan 3, 2023 · 0 comments · Fixed by #2120
Assignees
@guimachiavelli
Milestone
v1.0

Comments

@maryamsulemani97
Copy link
Contributor

maryamsulemani97 commented Jan 3, 2023 •
edited by guimachiavelli
Loading

  • Remove --snapshot-interval-sec
  • --schedule-snapshot now accepts an interval in seconds
  • If --schedule-snapshot is given without any value, snapshots are activated with the default value (24h)

To do

Some may be missing

Reference
@maryamsulemani97 maryamsulemani97 added this to the v1.0 milestone Jan 3, 2023
@maryamsulemani97 maryamsulemani97 mentioned this issue Jan 10, 2023
Merged
@guimachiavelli guimachiavelli mentioned this issue Jan 17, 2023
Merged
@guimachiavelli guimachiavelli linked a pull request Jan 17, 2023 that will close this issue
v1.0: New snapshot scheduling behaviour #2120
Merged
bors bot added a commit that referenced this issue Feb 6, 2023
@bors @maryamsulemani97 @guimachiavelli
Merge #2098
81d59b4 
2098: v1.0 r=guimachiavelli a=maryamsulemani97

Staging branch for v1.0.
Closes #2092, #2087, #2086, #2085, #2082, #2079, #2078, #2077, #2075, #2073, #2072, #2069, #2068, #2067, #2066, #2065

Co-authored-by: maryamsulemani97 <maryam@meilisearch.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
@bors bors bot closed this as completed in 079ae18 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guimachiavelli guimachiavelli

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

v1.0: New snapshot scheduling behaviour meilisearch/documentation
2 participants
@guimachiavelli @maryamsulemani97