-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
2102: v1.0: remove two-step dump import process r=guimachiavelli a=maryamsulemani97 closes #2067 ## Docs team review [This comment](meilisearch/meilisearch#2985 (comment)) mentions some version-specific update FYIs that we can document. I added the first (`enqueued` updates are not exported) and last (DB creation date isn't exported) points. The other two seem too dump version specific. Please let me know if I should add them as well. Co-authored-by: maryamsulemani97 <maryam@meilisearch.com>
2106: v1.0: New error type :`system` r=guimachiavelli a=maryamsulemani97 closes #2087 2108: v1.0: Clarify non-spacing mark normalization r=guimachiavelli a=guimachiavelli _Note for reviewers:_ the only section that needs to be reviewed is on lines 298-302, despite the size of the diff. Closes #2092 Co-authored-by: maryamsulemani97 <maryam@meilisearch.com> Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
2105: v1.0: Multi word synonyms are treated as phrases r=guimachiavelli a=maryamsulemani97 closes #2101 Co-authored-by: maryamsulemani97 <maryam@meilisearch.com> Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com> Co-authored-by: gui machiavelli <gui@meilisearch.com>
2110: v1.0: Remove mentions of `--disable-auto-batching` r=guimachiavelli a=guimachiavelli Closes #2085 Additionally, this PR also changes the wording of the `GET` documents endpoint so it doesn't use the word "batch" to keep our terminology consistent. 2111: v1.0: update to add `*` for date filters in task api r=guimachiavelli a=maryamsulemani97 closes #2109 Co-authored-by: gui machiavelli <hey@guimachiavelli.com> Co-authored-by: maryamsulemani97 <maryam@meilisearch.com>
2112: v1.0: accepted os versions to run the Meilisearch binary r=guimachiavelli a=maryamsulemani97 closes #2066 Co-authored-by: maryamsulemani97 <maryam@meilisearch.com> Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com> Co-authored-by: gui machiavelli <gui@meilisearch.com>
2142: v1.0: remove stable v1 mentions r=guimachiavelli a=guimachiavelli We found four old mentions reflecting our hopes and wishes for v1 around the documentation. Search was conducted using a grep-like tool with the following terms: - `v1` - `stable` - `unstable` - `in development` - `major` - `alpha` - `beta` Two mentions on the updating guide will be fixed by #2102. This PR removes the remaining two mentions on the FAQ. Co-authored-by: gui machiavelli <hey@guimachiavelli.com> Co-authored-by: gui machiavelli <gui@meilisearch.com>
dichotommy
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🧑🚀 🚀 🤞🏻
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging branch for v1.0.
Closes #2092, #2087, #2086, #2085, #2082, #2079, #2078, #2077, #2075, #2073, #2072, #2069, #2068, #2067, #2066, #2065