Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: /search name changes #1734

Merged
merged 4 commits into from
Jun 30, 2022
Merged

v0.28: /search name changes #1734

merged 4 commits into from
Jun 30, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1692

@maryamsulemani97 maryamsulemani97 added this to the v0.28 milestone Jun 16, 2022
@maryamsulemani97 maryamsulemani97 linked an issue Jun 16, 2022 that may be closed by this pull request
v0.28: /search name changes #1692
Closed
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review June 16, 2022 14:11
@maryamsulemani97 maryamsulemani97 requested review from guimachiavelli and dichotommy and removed request for guimachiavelli June 16, 2022 14:11
@guimachiavelli guimachiavelli requested a review from curquiza June 16, 2022 16:05
curquiza
curquiza approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

learn/advanced/filtering_and_faceted_search.md Outdated Show resolved Hide resolved
curquiza
curquiza approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@maryamsulemani97 maryamsulemani97 mentioned this pull request Jul 4, 2022
Closed
guimachiavelli
guimachiavelli reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting comments, but I think we renamed everything.

reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
reference/api/search.md Outdated Show resolved Hide resolved
guimachiavelli
guimachiavelli approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦝

@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
Closed
17 tasks
@guimachiavelli
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

Build succeeded:

@bors bors bot merged commit 4a53358 into v0.28 Jun 30, 2022
@bors bors bot deleted the v0.28--/search-name-changes branch June 30, 2022 11:13
@maryamsulemani97 maryamsulemani97 mentioned this pull request Jun 30, 2022
Merged
This was referenced Jul 6, 2022
Merged
Merged
@bidoubiwa bidoubiwa mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@dichotommy dichotommy Awaiting requested review from dichotommy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.

v0.28: /search name changes
3 participants
@maryamsulemani97 @guimachiavelli @curquiza