Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: /search name changes #1692

Closed
guimachiavelli opened this issue Jun 7, 2022 · 0 comments · Fixed by #1734
Closed

v0.28: /search name changes #1692

guimachiavelli opened this issue Jun 7, 2022 · 0 comments · Fixed by #1734
Assignees
@maryamsulemani97
Milestone
v0.28

Comments

@guimachiavelli
Copy link
Member

v0.28 renames a lot of properties and parameters for the /search endpoints:

Request changes

  • matches request parameter to showMatchesPosition
  • facetsDistribution request parameter to facets

Response changes

  • _matchesInfo response parameter to _matchesPosition
  • nbHits response parameter to estimatedTotalHits
  • facetsDistribution response parameter to facetDistribution
  • Remove exhaustiveNbHits
  • Remove exhaustiveFacetsCount

References

Spec: meilisearch/specifications#135
Issue on core: meilisearch/meilisearch#2376
SME: @gmourier
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 7, 2022
@guimachiavelli guimachiavelli mentioned this issue Jun 15, 2022
Merged
@maryamsulemani97 maryamsulemani97 mentioned this issue Jun 16, 2022
Merged
@maryamsulemani97 maryamsulemani97 linked a pull request Jun 16, 2022 that will close this issue
v0.28: /search name changes #1734
Merged
bors bot added a commit that referenced this issue Jul 11, 2022
@bors @guimachiavelli
@dichotommy @maryamsulemani97
Merge #1707
00cb6df 
1707: v0.28 r=guimachiavelli a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.28.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes #1687, #1688, #1691, #1692, #1693, #1694, #1699, #1700, #1701, #1702, #1703, #1704, #1706, #1722, #1727, #561

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: Tommy Melvin <tommy@meilisearch.com>
Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
@bors bors bot closed this as completed in 4a53358 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryamsulemani97 maryamsulemani97

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging a pull request may close this issue.

v0.28: /search name changes meilisearch/documentation
2 participants
@guimachiavelli @maryamsulemani97