Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes regarding Meilisearch v0.27.0 #190

Closed
brunoocasali opened this issue Apr 6, 2022 · 5 comments
Closed

Changes regarding Meilisearch v0.27.0 #190

brunoocasali opened this issue Apr 6, 2022 · 5 comments
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Apr 6, 2022

This issue gathers the changes related to the v0.27.0 of Meilisearch that will impact the integrations.

Release date: 09/05/2022

The whole milestone of v0.27.0 is here: https://github.com/meilisearch/meilisearch/milestone/28


Docker run changes

Related to:

Meilisearch docker image has changed a lot internally in order to make it simpler to run and maintain:

old way: ❌
docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics
new way: ✅
docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest meilisearch --no-analytics

This change will be made by our internal tool, just need to be reviewed.

Support nested fields

Related to:

In this new version, Meilisearch will add support to access nested fields, which means now we can define the searchableAttributes the value of person.documents.passport directly, without having to deal with the nesting definition.

According to the spec, the API will support the usage of nested fields in every place we need a document attribute (eg. searchableAttributes, attributesToRetrieve, filterableAttributes, and so on).

Since this change does not affect any integration directly, we could still ensure that the behavior is maintained through tests.

Customize the typo tolerance

Related to:

Add a typoTolerance index settings resource to manage customization of the typo tolerance feature at the index level.

  • Expose typoTolerance object on /indexes/:index_uid/settings endpoints.
  • Add GET/POST/DELETE - /indexes/:index_uid/settings/typo-tolerance endpoints.

The typoTolerance object definition is made of the following properties:

  • enabled type (boolean)
  • disableOnAttributes type (array[string])
  • disableOnWords type (array[string])
  • minWordSizeForTypos type (object)
    • oneTypo type (int)
    • twoTypos type (int)

More information about what each field does could be checked in the spec.

We will provide a good first issue for some of the SDKs, and the Integrations team will be responsible to implement the feature on the others.

  • Integrations team: Python, JavaScript, PHP, .NET.
  • Community: Go, Symfony, Java, Swift, Rust, Dart, Ruby, Ruby on Rails.

😃 Friendly reminder is about the testing, we just need to ensure our integration is correctly calling the endpoint with the correct values, we should not check if the typo tolerance is working.

Improve and stabilize cropping and highlighting

Related to:

This new version comes with the possibility to customize the highlighting tag we use to mark the important parts of the search result.

Add support to use these new search attributes:

  • highlightPreTag type (string default "<em>")
    • could be any valid string, no need to validate.
  • highlightPostTag type (string default "</em>")
    • could be any valid string, no need to validate.
  • cropMarker type (string default "…")
    • could be any valid string, no need to validate.

For some particular SDK maybe there is no change needed in the public API, but we still must add some tests to make
sure the SDK will handle the new parameters correctly.


[EDIT 25 April]

Code samples update

1. Update search_parameter_guide_crop_1 PR:

Change the value of cropLength from 10 to 5.

2. New search_parameter_guide_crop_marker_1 PR:

Search request in the movies index with these params:

  • q: "shifu",
  • cropMarker: "[…]",
  • attributesToCrop: ["overview"]

3. New search_parameter_guide_highlight_tag_1 PR:

Search request in the movies index with these params:

  • q: "winter feast",
  • attributesToHighlight: ["overview"],
  • highlightPreTag: "<span class=\"highlight\">"
  • highlightPostTag: "</span>"

4) Typo tolerance changes::

Check this PR to see all the changes regarding the typo tolerance meilisearch/documentation#1606.
⚠️ Only for the required SDKs.

@brunoocasali brunoocasali added the Meilisearch bump Changes related to the Meilisearch bump version label Apr 6, 2022
This was referenced Apr 11, 2022
@brunoocasali
Copy link
Member Author

FYI: @meilisearch/integration-team

Regarding the typo-tolerance implementation, I moved Ruby/Rails repositories to the community side. I will implement it in the .NET package instead.

@brunoocasali
Copy link
Member Author

I created all the issues and automated PRs. Let me know if you have any problem :)

@brunoocasali
Copy link
Member Author

@meilisearch/integration-team I've added the code-samples section of the issue as we agreed in our internal meeting :)

@bidoubiwa
Copy link
Contributor

Changes in the typo tolerance code-samples:

get_typo_tolerance => get_typo_tolerance_1
update_typo_tolerance => update_typo_tolerance_1
reset_typo_tolerance => reset_typo_tolerance_1

meili-bors bot added a commit to meilisearch/meilisearch-js that referenced this issue May 9, 2022
1188: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-dart that referenced this issue May 9, 2022
150: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
meili-bors bot added a commit to meilisearch/meilisearch-ruby that referenced this issue May 9, 2022
311: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit to meilisearch/meilisearch-php that referenced this issue May 9, 2022
312: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #313 
- #315 
- #316 
- #317 
- #318 
- #320 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
bors bot added a commit to meilisearch/meilisearch-java that referenced this issue May 9, 2022
365: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #366
- #370 
- #374 
- #375 
- #377

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
bors bot added a commit to meilisearch/meilisearch-python that referenced this issue May 9, 2022
439: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #440 
- #443 
- #444 
- #445
- #450 


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-go that referenced this issue May 9, 2022
286: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #287 
- #289
- #290 
- #291 
- #294
- #293 

# Release
**:warning:** The go package didn't need a version update CI will publish the package once the `Publish release` will be done. However, a version file exists and this is only for analytics but it already is on the next version (the v0.19.1).

This version makes this package compatible with MeiliSearch v0.27.0🎉 
Check out the changelog of [MeiliSearch v0.27.0](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.27.0) for more information about the changes.

## 🚀 Enhancements

* Feature/Analytics (#279) `@brunoocasali`
* Add new methods for the new typo tolerance settings #294 `@alallema`
`Index.GetTypoTolerance()`
`Index.UpdateTypoTolerance(params)`
`Index.ResetTypoTolerance()`
* Ensure nested field support #290 `@alallema`
* Add new search parameters highlightPreTag, highlightPostTag and cropMarker #291 `@alallema`


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
bors bot added a commit to meilisearch/meilisearch-rust that referenced this issue May 9, 2022
258: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
meili-bors bot added a commit to meilisearch/meilisearch-swift that referenced this issue May 9, 2022
280: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/meilisearch-swift that referenced this issue May 9, 2022
280: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-dotnet that referenced this issue May 18, 2022
256: Changes related to the next Meilisearch release (v0.27.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@brunoocasali brunoocasali removed the WIP Work in progress issue label May 19, 2022
@brunoocasali
Copy link
Member Author

Congratulations team, we made it! 🎉 🎉

congratulations everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Development

No branches or pull requests

2 participants