Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Typo tolerance #263

Merged
merged 7 commits into from
Mar 17, 2023
Merged

[Feature] Add Typo tolerance #263

merged 7 commits into from
Mar 17, 2023

Conversation

ahmednfwela
Copy link
Collaborator

@ahmednfwela ahmednfwela commented Mar 11, 2023 •
edited
Loading

Fixes #152
Depends on #262

  • Tests Added

@ahmednfwela ahmednfwela mentioned this pull request Mar 11, 2023
Merged
1 task
@brunoocasali
Copy link
Member

Can you fix the conflicts here?

@ahmednfwela
Copy link
Collaborator Author

Conflicts fixed and rebased on #262

@brunoocasali brunoocasali added the enhancement New feature or request label Mar 15, 2023
brunoocasali
brunoocasali reviewed Mar 15, 2023
View reviewed changes
lib/src/index_settings.dart Outdated Show resolved Hide resolved
lib/src/min_word_size_for_typos.dart Outdated Show resolved Hide resolved
lib/src/min_word_size_for_typos.dart Outdated Show resolved Hide resolved
lib/src/typo_tolerance.dart Outdated Show resolved Hide resolved
lib/src/typo_tolerance.dart Outdated Show resolved Hide resolved
@ahmednfwela
Copy link
Collaborator Author

I moved all the index settings into a settings folder and added a barrel file to export them cleanly

brunoocasali
brunoocasali approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahmednfwela 🎉

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 17, 2023

Build succeeded:

@bors bors bot merged commit de2dc11 into meilisearch:main Mar 17, 2023
@ahmednfwela ahmednfwela deleted the typoTolerance branch March 17, 2023 22:21
bors bot added a commit that referenced this pull request Mar 20, 2023
@bors @ahmednfwela
Merge #264
1c6d67b 
264: [Feature] Add pagination settings r=brunoocasali a=ahmednfwela

Fixes #196
Depends on #263

- [x] Tests Added

Co-authored-by: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the typo tolerance customization
2 participants
@ahmednfwela @brunoocasali