Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add pagination settings #264

Merged
merged 9 commits into from
Mar 20, 2023
Merged

[Feature] Add pagination settings #264

merged 9 commits into from
Mar 20, 2023

Conversation

ahmednfwela
Copy link
Collaborator

@ahmednfwela ahmednfwela commented Mar 11, 2023 •
edited
Loading

Fixes #196
Depends on #263

  • Tests Added

@ahmednfwela ahmednfwela mentioned this pull request Mar 11, 2023
Merged
1 task
@brunoocasali
Copy link
Member

Can you fix the conflicts here?

@ahmednfwela
Copy link
Collaborator Author

Conflicts fixed and rebased on #263

brunoocasali
brunoocasali reviewed Mar 15, 2023
View reviewed changes
lib/src/pagination_settings.dart Outdated Show resolved Hide resolved
lib/src/pagination_settings.dart Outdated Show resolved Hide resolved
@ahmednfwela
Copy link
Collaborator Author

added tests, and rebased on #263

@brunoocasali
Copy link
Member

Sorry @ahmednfwela, but can you rebase here? It is hard to make the review with multiple changes happening

@ahmednfwela
Copy link
Collaborator Author

done @brunoocasali

brunoocasali
brunoocasali approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 @ahmednfwela thanks a lot! :D

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 20, 2023

Build succeeded:

@bors bors bot merged commit 1c6d67b into meilisearch:main Mar 20, 2023
bors bot added a commit that referenced this pull request Mar 20, 2023
@bors @ahmednfwela
Merge #265
5bb995d 
265: [Feature] Add faceting settings r=brunoocasali a=ahmednfwela

Fixes #197
Depends on #264 

- [x] Tests Added

Co-authored-by: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
@ahmednfwela ahmednfwela deleted the feat/pagination-settings branch March 20, 2023 04:06
@brunoocasali brunoocasali added the enhancement New feature or request label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the pagination setting customization at the index level
2 participants
@ahmednfwela @brunoocasali