Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to the pagination setting customization at the index level #568

Merged
merged 13 commits into from
Mar 6, 2023
Merged

Add support to the pagination setting customization at the index level #568

merged 13 commits into from
Mar 6, 2023

Conversation

dennxa
Copy link
Contributor

@dennxa dennxa commented Mar 5, 2023 •
edited
Loading

Pull Request

Related issue

Fixes #411

What does this PR do?

  • Add the new methods to customize pagination
    -GET /indexes/:index_uid/settings/pagination
    -PATCH /indexes/:index_uid/settings/pagination
    -DELETE /indexes/:index_uid/settings/pagination
  • Add tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@dennxa
Add the new methods to customize pagination:
d18a8c8 
 -GET /indexes/:index_uid/settings/pagination
 -PATCH /indexes/:index_uid/settings/pagination
 -DELETE /indexes/:index_uid/settings/pagination
 Add tests
@alallema alallema added the enhancement New feature or request label Mar 6, 2023
alallema
alallema reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR @dennxa ❤️!
Really nice 🚀
I have added some suggestions, also you will need to run the linter with:

bash ./scripts/lint.sh

src/main/java/com/meilisearch/sdk/Index.java Outdated Show resolved Hide resolved
src/main/java/com/meilisearch/sdk/SettingsHandler.java Outdated Show resolved Hide resolved
src/main/java/com/meilisearch/sdk/model/Settings.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Show resolved Hide resolved
dennxa and others added 8 commits March 6, 2023 10:44
@dennxa @alallema
Update src/main/java/com/meilisearch/sdk/Index.java
d70de3b 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/main/java/com/meilisearch/sdk/SettingsHandler.java
e7ce318 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/main/java/com/meilisearch/sdk/model/Settings.java
53a6367 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
49991fb 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
4bfa995 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
59f6744 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa
Update src/test/java/com/meilisearch/integration/SettingsTest.java
473dbf9
@dennxa
linter executed
be97458
@dennxa
Copy link
Contributor Author

dennxa commented Mar 6, 2023

Thanks for the suggestions @alallema, I already commit all the changes.

alallema
alallema reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for the modifications
The tests were broken. I leave you some suggestions 😊

src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
src/test/java/com/meilisearch/integration/SettingsTest.java Outdated Show resolved Hide resolved
dennxa and others added 3 commits March 6, 2023 11:31
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
b5320bb 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
5169eda 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa @alallema
Update src/test/java/com/meilisearch/integration/SettingsTest.java
56d8287 
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@dennxa
Copy link
Contributor Author

dennxa commented Mar 6, 2023

Hi! all is done, I think that the tests should be passed now.

alallema
alallema approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you so @dennxa much for this PR ✨
LGTM! 🎉

@alallema
Copy link
Contributor

alallema commented Mar 6, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@bors bors bot merged commit 27ae5cc into meilisearch:main Mar 6, 2023
@alallema alallema mentioned this pull request May 9, 2023
Merged
meili-bors bot added a commit that referenced this pull request May 9, 2023
@meili-bors @meili-bot
Merge #598
447547e 
598: Update version for the next release (v0.11.1) r=alallema a=meili-bot

## 🚀 Enhancements

* Add support to the pagination setting customization at the index level (#568) `@dennxa`
     *  `getPaginationSettings`
     *  `updatePaginationSettings`
     *  `resetPaginationSettings`
* Create an enum to handle the Task Status (#566) `@TheClerici`
* Add support to the sortable attributes settings (#570) `@albajarazeth`
     *  `getSortableAttributesSettings`
     *  `updateSortableAttributesSettings`
     *  `resetSortableAttributesSettings`
* Add support to the faceting setting customization at the index level (#577) `@MaAnCoSa`
     * `getFacetingSettings`
     * `updateFacetingSettings`
     * `resetFacetingSettings`
* Add explicitly requirement of `okhttp` library (#594) `@brunoocasali`
* Update Gradle tooling (#596) `@brunoocasali`

Thanks again to `@MaAnCoSa,` `@PotatoDoge,` `@TheClerici,` `@alallema,` `@albajarazeth,`  `@brunoocasali,` `@curquiza,` `@dennxa` and `@oraliahdz` 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the pagination setting customization at the index level
2 participants
@dennxa @alallema