Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the faceting setting customization at the index level #577

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

MaAnCoSa
Copy link
Contributor

Pull Request

Related issue

Fixes #412

What does this PR do?

  • Added new methods for faceting customization:
    -GET /indexes/:index_uid/settings/faceting
    -PATCH /indexes/:index_uid/settings/faceting
    -DELETE /indexes/:index_uid/settings/faceting
  • Added tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MaAnCoSa for this PR ❤️
The additions of code are correct but it would be necessary to remove the added files which should not be there all in the meili_data directory

src/main/java/com/meilisearch/sdk/SettingsHandler.java Outdated Show resolved Hide resolved
MaAnCoSa and others added 2 commits March 30, 2023 10:41
Deletes the added files in the meili_data directory.
Update comments for the DELETE method.

Co-authored-by: Amélie <alallema@users.noreply.github.com>
@MaAnCoSa
Copy link
Contributor Author

Hi @alallema! Thank you! I removed the meili_data directory and commited the change about the reset. I Hope everything is alright now.

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaAnCoSa for this PR ❤️
LGTM! 🚀

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Build succeeded:

@bors bors bot merged commit f40fdd0 into meilisearch:main Mar 30, 2023
@alallema alallema added the enhancement New feature or request label May 9, 2023
meili-bors bot added a commit that referenced this pull request May 9, 2023
598: Update version for the next release (v0.11.1) r=alallema a=meili-bot

## 🚀 Enhancements

* Add support to the pagination setting customization at the index level (#568) `@dennxa`
     *  `getPaginationSettings`
     *  `updatePaginationSettings`
     *  `resetPaginationSettings`
* Create an enum to handle the Task Status (#566) `@TheClerici`
* Add support to the sortable attributes settings (#570) `@albajarazeth`
     *  `getSortableAttributesSettings`
     *  `updateSortableAttributesSettings`
     *  `resetSortableAttributesSettings`
* Add support to the faceting setting customization at the index level (#577) `@MaAnCoSa`
     * `getFacetingSettings`
     * `updateFacetingSettings`
     * `resetFacetingSettings`
* Add explicitly requirement of `okhttp` library (#594) `@brunoocasali`
* Update Gradle tooling (#596) `@brunoocasali`

Thanks again to `@MaAnCoSa,` `@PotatoDoge,` `@TheClerici,` `@alallema,` `@albajarazeth,`  `@brunoocasali,` `@curquiza,` `@dennxa` and `@oraliahdz` 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to the facet setting customization at the index level
2 participants