-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to the faceting setting customization at the index level #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MaAnCoSa for this PR ❤️
The additions of code are correct but it would be necessary to remove the added files which should not be there all in the meili_data
directory
Deletes the added files in the meili_data directory.
Update comments for the DELETE method. Co-authored-by: Amélie <alallema@users.noreply.github.com>
Hi @alallema! Thank you! I removed the meili_data directory and commited the change about the reset. I Hope everything is alright now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaAnCoSa for this PR ❤️
LGTM! 🚀
bors merge |
Build succeeded: |
598: Update version for the next release (v0.11.1) r=alallema a=meili-bot ## 🚀 Enhancements * Add support to the pagination setting customization at the index level (#568) `@dennxa` * `getPaginationSettings` * `updatePaginationSettings` * `resetPaginationSettings` * Create an enum to handle the Task Status (#566) `@TheClerici` * Add support to the sortable attributes settings (#570) `@albajarazeth` * `getSortableAttributesSettings` * `updateSortableAttributesSettings` * `resetSortableAttributesSettings` * Add support to the faceting setting customization at the index level (#577) `@MaAnCoSa` * `getFacetingSettings` * `updateFacetingSettings` * `resetFacetingSettings` * Add explicitly requirement of `okhttp` library (#594) `@brunoocasali` * Update Gradle tooling (#596) `@brunoocasali` Thanks again to `@MaAnCoSa,` `@PotatoDoge,` `@TheClerici,` `@alallema,` `@albajarazeth,` `@brunoocasali,` `@curquiza,` `@dennxa` and `@oraliahdz` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Pull Request
Related issue
Fixes #412
What does this PR do?
-GET /indexes/:index_uid/settings/faceting
-PATCH /indexes/:index_uid/settings/faceting
-DELETE /indexes/:index_uid/settings/faceting
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!