Skip to content

Commit

Permalink
Merge #1561
Browse files Browse the repository at this point in the history
1561: fix(type): add canceled status to type TaskStatus r=atoulmet a=nicolasvienot

# Pull Request

## Related issue
Fixes #1560

## What does this PR do?
In Meilisearch `v0.30.0`, the feature `Cancel processing and enqueued tasks` [has been added](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0).
By doing so, they added a task status `canceled`. It's documented [here](https://www.meilisearch.com/docs/reference/api/tasks#status).
The status `canceled` is missing in the type `TaskStatus` in meilisearch-js.

- Add `canceled` status to `TaskStatus` type
- Update a test in the cancel part of the task tests

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: nicolasvienot <nvienot@gmail.com>
Co-authored-by: Alexia Toulmet <alexia.toulmet@gmail.com>
  • Loading branch information
3 people authored Aug 7, 2023
2 parents 613576a + c978148 commit 2cba878
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ export const enum TaskStatus {
TASK_PROCESSING = 'processing',
TASK_FAILED = 'failed',
TASK_ENQUEUED = 'enqueued',
TASK_CANCELED = 'canceled',
}

export const enum TaskTypes {
Expand Down

0 comments on commit 2cba878

Please sign in to comment.