fix(type): add canceled status to type TaskStatus #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulmet
changed the title
atoulmet
changed the title
atoulmet
changed the title
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
1561: fix(type): add canceled status to type TaskStatus r=atoulmet a=nicolasvienot # Pull Request ## Related issue Fixes #1560 ## What does this PR do? In Meilisearch `v0.30.0`, the feature `Cancel processing and enqueued tasks` [has been added](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0). By doing so, they added a task status `canceled`. It's documented [here](https://www.meilisearch.com/docs/reference/api/tasks#status). The status `canceled` is missing in the type `TaskStatus` in meilisearch-js. - Add `canceled` status to `TaskStatus` type - Update a test in the cancel part of the task tests ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: nicolasvienot <nvienot@gmail.com>
|
Build failed: |
atoulmet
suggested changes
Aug 7, 2023
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1560
What does this PR do?
In Meilisearch
v0.30.0, the featureCancel processing and enqueued taskshas been added.By doing so, they added a task status
canceled. It's documented here.The status
canceledis missing in the typeTaskStatusin meilisearch-js.canceledstatus toTaskStatustypePR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!