Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code style after configuration changes #1638

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix code style after configuration changes #1638

merged 2 commits into from
Apr 3, 2024

Conversation

brunoocasali
Copy link
Member

This PR should be merged right after the #1616

@brunoocasali
Copy link
Member Author

@curquiza I'm going to self-approve this one, since it is part of the #1616 anyway!

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (39a874f) to head (36c3d0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   97.50%   97.51%   +0.01%     
==========================================
  Files          22       22              
  Lines         842      846       +4     
  Branches       93       86       -7     
==========================================
+ Hits          821      825       +4     
- Misses         20       21       +1     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunoocasali brunoocasali merged commit 406b689 into main Apr 3, 2024
6 checks passed
@brunoocasali brunoocasali deleted the fix-style branch April 3, 2024 15:10
@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label May 2, 2024
meili-bors bot added a commit that referenced this pull request May 6, 2024
1648: Update version for the next release (v0.39.0) r=brunoocasali a=meili-bot

## 🚀 Enhancements

* feat: hybrid search improvements for v1.8.x (#1647) `@mdubus`
* Add `null` to Embedder type (#1646) `@amit-ksh`
* Add searchCutoffMs index setting (#1643, #1645) `@amit-ksh`
    ```js
    client.index('movies').getSearchCutoffMs()
    client.index('movies').updateSearchCutoffMs(150)
    client.index('movies').resetSearchCutoffMs()
    ```

## ⚙️ Maintenance/misc

* Update ESLint, Prettier, TypeScript and fix/improve their configuration files (#1616) `@flevi29`
* Fix code style after configuration changes (#1638) `@brunoocasali`

Thanks again to `@amit-ksh,` `@brunoocasali,` `@curquiza,` `@flevi29,` `@mdubus,` `@meili-bors[bot]` ! 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants