feat: hybrid search improvements for v1.8.x #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubus
force-pushed
the
hybrid-search-improvements
branch
from
363d8ab
to
8d368d6
Compare
mdubus
commented
Apr 23, 2024
| expect(response).toEqual({ | ||
| default: { | ||
| ...newEmbedder.default, | ||
| apiKey: '<yoXXXXX...', |
Comment on lines
+476
to
+481
| expect(response).toHaveProperty('hits') | ||
| expect(response).toHaveProperty('semanticHitCount') | ||
| // Those fields are no longer returned by the search response | ||
| // We want to ensure that they don't appear in it anymore | ||
| expect(response).not.toHaveProperty('vector') | ||
| expect(response).not.toHaveProperty('_semanticScore') |
There was a problem hiding this comment.
I test that I retrieve the hits and semanticHitCount fields correctly.
And since the vector and _semanticScore fields have been removed from the response, I check that I don't retrieve them anymore
Comment on lines
+484
to
+488
| test(`${permission} key: search without vectors`, async () => { | ||
| const client = await getClient(permission) | ||
| const response = await client.index(index.uid).search('prince', {}) | ||
|
|
||
| expect(response).not.toHaveProperty('semanticHitCount') |
There was a problem hiding this comment.
Creation of this specific test to make sure that with a "non-vector" search, I don't retrieve the semanticHitCount field in the response
| @@ -146,6 +149,41 @@ describe.each([{ permission: 'Master' }, { permission: 'Admin' }])( | |||
| expect(response).toMatchSnapshot() | |||
| }) | |||
|
|
|||
| test(`${permission} key: Update embedders settings `, async () => { | |||
There was a problem hiding this comment.
Creation of a new test to test the embedder's addition on the settings route (it was forgotten previously).
Since it needs the activation of the vectorStore exp. feature, I thought it would be best to create a specific test for this one
| @@ -183,6 +221,29 @@ describe.each([{ permission: 'Master' }, { permission: 'Admin' }])( | |||
| expect(response).toMatchSnapshot() | |||
| }) | |||
|
|
|||
| test(`${permission} key: Reset embedders settings `, async () => { | |||
There was a problem hiding this comment.
Creation of a new test to test the embedders deletion on the settings route
mdubus
force-pushed
the
hybrid-search-improvements
branch
from
8d368d6
to
94b1875
Compare
9 tasks
meili-bors bot
added a commit
that referenced
this pull request
May 6, 2024
1648: Update version for the next release (v0.39.0) r=brunoocasali a=meili-bot ## 🚀 Enhancements * feat: hybrid search improvements for v1.8.x (#1647) `@mdubus` * Add `null` to Embedder type (#1646) `@amit-ksh` * Add searchCutoffMs index setting (#1643, #1645) `@amit-ksh` ```js client.index('movies').getSearchCutoffMs() client.index('movies').updateSearchCutoffMs(150) client.index('movies').resetSearchCutoffMs() ``` ## ⚙️ Maintenance/misc * Update ESLint, Prettier, TypeScript and fix/improve their configuration files (#1616) `@flevi29` * Fix code style after configuration changes (#1638) `@brunoocasali` Thanks again to `@amit-ksh,` `@brunoocasali,` `@curquiza,` `@flevi29,` `@mdubus,` `@meili-bors[bot]` ! 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1641
What does this PR do?
vectorand_semanticScorefields from the SearchResponsedistributionfield to all embeddersRESTandOllamaCI fails because of 2 things:
distributionfield is not retrieved correctly on thesettings/embeddersroutes (seedistributionfield not retrieved correctly on thesettings/embeddersroute meilisearch#4594)Ollamaembedder has missing fields on GET meilisearch#4595 )Once those 2 things are fixed, it should be fine 🙌
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!