Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the next Meilisearch release (v1.0.0) #635

Merged
merged 10 commits into from
Feb 6, 2023

Conversation

meili-bot
Copy link
Contributor

Related to this issue: meilisearch/integration-guides#230

This PR:

  • gathers the changes related to the next Meilisearch release (v1.0.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v1.0.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.0.0) is out.

This PR is auto-generated for the pre-release week purpose.

@alallema alallema marked this pull request as ready for review February 1, 2023 17:03
@alallema alallema requested review from alallema and brunoocasali and removed request for alallema February 1, 2023 17:06
@@ -98,7 +98,7 @@ def test_get_task_inexistent(client):
def create_tasks(empty_index, small_movies):
"""Ensures there are some tasks present for testing."""
index = empty_index()
index.update_ranking_rules(["type", "exactness"])
index.update_ranking_rules(["typo", "exactness"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

brunoocasali
brunoocasali previously approved these changes Feb 2, 2023
README.md Show resolved Hide resolved
sanders41
sanders41 previously approved these changes Feb 3, 2023
@sanders41
Copy link
Collaborator

@alallema is the plan to go to 1.0 for this package when Meilisearch 1.0 is released? The reason I ask is #449, #610, and #604 are all breaking changes.

@alallema
Copy link
Contributor

alallema commented Feb 6, 2023

@alallema is the plan to go to 1.0 for this package when Meilisearch 1.0 is released? The reason I ask is #449, #610, and #604 are all breaking changes.

Not yet no, for the moment we are only releasing a version for Meilisearch v1. We plan to release a v1 on the SDKs when necessary and also when we are sure to be able to ensure a stable release.

Should this just be v1 instead of v1.0.0? At this point any breaking change that would stop the SDK from working would be v2 of Meilisearch so this SDK should work with any v1.x.x version.

We finally decide with the integration team to keep the current ntoation with the full version

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema
Copy link
Contributor

alallema commented Feb 6, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

@bors bors bot merged commit 0c49fdd into main Feb 6, 2023
@bors bors bot deleted the bump-meilisearch-v1.0.0 branch February 6, 2023 11:38
bors bot added a commit that referenced this pull request Feb 6, 2023
678: Update version for the next release (v0.24.0) r=alallema a=alallema

This version makes this package compatible with Meilisearch v1.0.0 🎉
Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes(#635).

## ⚠️ Breaking changes

* Make the usage of the module typing consistent (#625) `@pbrochar`
* Put all dates to `datetime` type for consistency. Class impacted: `Task` and `TasInfo` (#661) `@Azanul`
* Change `details` fields in `Task` class `Dict[str, Any]` -> `Union[Dict[str, Any], None]` (#664) `@Azanul`

## 🚀 Enhancements

* Added `update_documents_csv(str_documents: str, primary_key: Optional[str] = None) -> TaskInfo` (#654) `@sajdakabir`

## 🐛 Bug Fixes

* Include py.typed in package build (#637) `@sanders41`

Thanks again to `@Azanul,` `@alallema,` `@pbrochar,` `@sajdakabir,` `@sanders41!` 🎉



Co-authored-by: alallema <amelie@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants