feat(detection): Ignore invisible nodes when extracting text under mouse #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
4 times, most recently
from
5459476
to
12db918
Compare
|
Will completely change this to be based on snowpack soon! |
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
12db918
to
98ae30c
Compare
melink14
commented
Jul 7, 2021
melink14
commented
Jul 7, 2021
melink14
force-pushed
the
melink14/snowpack
branch
from
1a3fe7a
to
c48843c
Compare
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
98ae30c
to
62961c9
Compare
melink14
force-pushed
the
melink14/snowpack
branch
from
c48843c
to
6f87467
Compare
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
62961c9
to
66fdff6
Compare
melink14
force-pushed
the
melink14/snowpack
branch
from
6f87467
to
12bb6a2
Compare
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
2 times, most recently
from
47afb7f
to
7c7851b
Compare
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage ? 37.50%
=======================================
Files ? 3
Lines ? 1384
Branches ? 18
=======================================
Hits ? 519
Misses ? 865
Partials ? 0 Continue to review full report at Codecov.
|
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
7c7851b
to
8d2c396
Compare
melink14
force-pushed
the
melink14/snowpack
branch
from
12bb6a2
to
c611667
Compare
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
8d2c396
to
6bd752e
Compare
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
6bd752e
to
1260f33
Compare
Specifically, ignore `display: none` and `visibility: hidden`. This change is also the first unit tested change so contains the initial configuration of testing. (See #159 for details on decisions). Testing Stack: @web/test-runner + Mocha/Chai/Sinon + Puppeteer Headless Chrome. Works with vscode debugging for fast test driven development. With --coverage flag, we get a coverage report that we can upload to codecov. Fixes #366 Fixes #159
melink14
force-pushed
the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
from
1260f33
to
73d825a
Compare
melink14
deleted the
melink14/issue366/Multi-layered-HTML-prevents-word-detection
branch
melink14
pushed a commit
that referenced
this pull request
Jul 17, 2021
## [2.0.0](v1.2.6...v2.0.0) (2021-07-17) ### ⚠ BREAKING CHANGES * This version includes optional chaining requiring Chrome >=80 ### Features * Force Google Docs to use HTML mode instead of canvas mode ([#596](#596)) ([94b60a6](94b60a6)), closes [#593](#593) * **detection:** Ignore invisible nodes when extracting text under mouse ([#561](#561)) ([cb97f36](cb97f36)), closes [#159](#159) [#366](#366) [#159](#159) ### Bug Fixes * **dict:** Update dictionaries to latest versions. ([#581](#581)) ([77189c3](77189c3)) * Skip text processing when range is null ([#598](#598)) ([ae55bff](ae55bff)), closes [#386](#386) ### Code Refactoring * Migrate from webpack to snowpack for build step ([#583](#583)) ([1bdd3d3](1bdd3d3))
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, ignore
display: noneandvisibility: hidden.This change is also the first unit tested change so contains the initial
configuration of testing. (See #159 for details on decisions).
Testing Stack: @web/test-runner + Mocha/Chai/Sinon + Puppeteer Headless Chrome.
Works with vscode debugging for fast test driven development.
Fixes #366
Fixes #159