Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(detection): Ignore invisible nodes when extracting text under mouse #561

Merged
merged 1 commit into from
Jul 16, 2021
Merged

feat(detection): Ignore invisible nodes when extracting text under mouse #561

merged 1 commit into from
Jul 16, 2021

Commits on Jul 16, 2021

  1. feat(detection): Ignore invisible nodes when extracting text under mouse 

    Specifically, ignore `display: none` and `visibility: hidden`.

This change is also the first unit tested change so contains the initial
configuration of testing. (See #159 for details on decisions).

Testing Stack: @web/test-runner + Mocha/Chai/Sinon + Puppeteer Headless Chrome.
Works with vscode debugging for fast test driven development.

With --coverage flag, we get a coverage report that we can upload to
codecov.

Fixes #366
Fixes #159
    @melink14
    melink14 committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    73d825a View commit details
    Browse the repository at this point in the history