Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Emulate text affecting properties of input/textarea elements when creating fake #886

Conversation

melink14
Copy link
Owner

@melink14 melink14 commented Mar 1, 2022

Previously, it was copying no styles and thus often would produce an inaccurate duplicate of the real text.

Fixes #672

@melink14 melink14 force-pushed the melink14/issue672/Fake-Text-Areas-not-actually-copying-styles-from-real-textareas-Breaks-Google-Search-Input branch from 083ca59 to 4bd872e Compare March 23, 2022 14:03
@melink14 melink14 force-pushed the melink14/issue672/Fake-Text-Areas-not-actually-copying-styles-from-real-textareas-Breaks-Google-Search-Input branch from 4bd872e to d0868ec Compare April 3, 2022 01:13
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #886 (2a5e99d) into main (4f6374b) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   76.44%   76.55%   +0.11%     
==========================================
  Files           7        7              
  Lines        2984     2999      +15     
  Branches      161      160       -1     
==========================================
+ Hits         2281     2296      +15     
  Misses        702      702              
  Partials        1        1              
Impacted Files Coverage Δ
extension/rikaicontent.ts 75.40% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6374b...2a5e99d. Read the comment docs.

@melink14 melink14 marked this pull request as ready for review April 3, 2022 02:33
@melink14 melink14 merged commit 23fc0df into main Apr 3, 2022
@melink14 melink14 deleted the melink14/issue672/Fake-Text-Areas-not-actually-copying-styles-from-real-textareas-Breaks-Google-Search-Input branch April 3, 2022 05:12
melink14 pushed a commit that referenced this pull request Apr 4, 2022
## [2.3.0](v2.2.5...v2.3.0) (2022-04-04)

### Features

* **ui:** Isolate rikaikun popup from host page via shadow DOM and `all: revert` ([#933](#933)) ([e6a6e7a](e6a6e7a)), closes [#221](#221)

### Bug Fixes

* **detection:** Copy text affecting style properties of input/textarea elements when creating fake ([#886](#886)) ([23fc0df](23fc0df)), closes [#672](#672)
* **dict:** Update dictionaries to latest versions ([#954](#954)) ([deae6f5](deae6f5))
* **ui:** Only show info popups in the main frame of a tab ([#948](#948)) ([90c7b21](90c7b21))
@melink14
Copy link
Owner Author

melink14 commented Apr 4, 2022

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake Text Areas not actually copying styles from real textareas (Breaks Google Search Input)
1 participant