fix(ui): Only show info popups in the main frame of a tab #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
melink14
commented
Apr 3, 2022
melink14
commented
- This includes the enable/help message as well as the copied to clipboard message.
- Adds a test for the clipboard message.
- Also removes a commented out piece of unused code from an visual screenshot test.
- This includes the enable/help message as well as the copied to clipboard message. - Adds a test for the clipboard message. - Also removes a commented out piece of unused code from an visual screenshot test.
Also adds a test for this case.
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 76.55% 79.65% +3.09%
==========================================
Files 7 7
Lines 2999 3003 +4
Branches 160 171 +11
==========================================
+ Hits 2296 2392 +96
+ Misses 702 610 -92
Partials 1 1
Continue to review full report at Codecov.
|
melink14
pushed a commit
that referenced
this pull request
Apr 4, 2022
## [2.3.0](v2.2.5...v2.3.0) (2022-04-04) ### Features * **ui:** Isolate rikaikun popup from host page via shadow DOM and `all: revert` ([#933](#933)) ([e6a6e7a](e6a6e7a)), closes [#221](#221) ### Bug Fixes * **detection:** Copy text affecting style properties of input/textarea elements when creating fake ([#886](#886)) ([23fc0df](23fc0df)), closes [#672](#672) * **dict:** Update dictionaries to latest versions ([#954](#954)) ([deae6f5](deae6f5)) * **ui:** Only show info popups in the main frame of a tab ([#948](#948)) ([90c7b21](90c7b21))
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.