Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Only show info popups in the main frame of a tab #948

Merged
merged 3 commits into from
Apr 3, 2022
Merged

fix(ui): Only show info popups in the main frame of a tab #948

merged 3 commits into from
Apr 3, 2022

Commits on Apr 3, 2022

  1. fix(ui): Only show info popups in the main frame of a tab 

    - This includes the enable/help message as well as the copied to clipboard message.
- Adds a test for the clipboard message.
- Also removes a commented out piece of unused code from an visual screenshot test.
    @melink14
    melink14 committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    398d193 View commit details
    Browse the repository at this point in the history

  2. fix(ui): Correctly omit mini help if option is disabled 

    Also adds a test for this case.
    @melink14
    melink14 committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    8fe49ad View commit details
    Browse the repository at this point in the history

  3. test(visual): Update baselines with new screenshots

    @github-actions
    github-actions[bot] committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    4ca7afc View commit details
    Browse the repository at this point in the history