Enable multiline tags #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing but on readthedocs it seems all is fine. |
|
Um wow thanks for working so much on this. I'm perfectly fine w/ a temporary hack assuming it doesn't go chaotic . @QuLogic can you think of any issues to the mpl doc build if we move tags to this release? |
JWCook
reviewed
Jul 7, 2024
|
@melissawm #103 should fix the test failures you're seeing here. |
Fixes for multiline tags
JWCook
approved these changes
Jul 7, 2024
|
I'm going to merge and cut a release since I think this is the best way to test it with at least a local matplotlib build. If it doesn't work, at least we tried :) Thank you all so much! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, this is a ridiculously ugly temporary solution for the parsing of multiline tags while we work on #101 and #92 . I am pretty sure I have a way forward with a more "sphinxy" approach using the domain, but I won't have the time to finish this before SciPy.
This PR adds a multiline parser for the tags in
Entry- like I said it is ugly but seems to work on the simpler cases. If you agree with testing this as a temporary solution, we can cut a 0.3.2 and keep working on the domain approach for a 1.0 later.cc @story645