Fixes for multiline tags #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This looks good but do you know why the tests didn't run on this PR? I'll try to run locally and if all is good I'll merge. Thank you so much!!! ❤️ ❤️ |
Probably because the GitHub Actions workflow is currently only triggered by merges into the main branch, and this is set to merge into your PR branch. |
|
I manually ran them here, and the tests pass: https://github.com/melissawm/sphinx-tags/actions/runs/9829948666/job/27135586549 |
|
That makes sense, I didn't notice, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test failures in #102, which were mostly due to problems with handling extraneous whitespace.