-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA] Bugfix: Improve NVCC cuda_std flags handling when it differs from cpp_std #8527
Conversation
Makes command-line more readable.
No coverage, no tests, unreadable, unused, likely premature optimization.
overrides.pop(OptionKey('std', machine=self.for_machine, | ||
lang=self.host_compiler.language), None) | ||
host_options = self.host_compiler.get_options().copy() | ||
if 'std' in host_options: | ||
del host_options['std'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcbaker I need some help here with Mypy type annotations. How do I express the idea that I want to delete the std
option both from the host compiler and from the overrides, that special flag being handled already beginning at line 638?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcbaker How should I handle the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless someone can come up with a better solution soon, disabling mypy for that line is fine.
Merged as #8596 so closing. |
Closes #8523 , plus minor cleanups.
@dcbaker, can this also be marked for backport to 0.57.2?