Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Bugfix: Improve NVCC cuda_std flags handling when it differs from cpp_std #8527

Closed
wants to merge 3 commits into from

Conversation

obilaniu
Copy link
Contributor

Closes #8523 , plus minor cleanups.

@dcbaker, can this also be marked for backport to 0.57.2?

@dcbaker dcbaker added this to the 0.57.2 milestone Mar 12, 2021
No coverage, no tests, unreadable, unused, likely premature
optimization.
Comment on lines +626 to +630
overrides.pop(OptionKey('std', machine=self.for_machine,
lang=self.host_compiler.language), None)
host_options = self.host_compiler.get_options().copy()
if 'std' in host_options:
del host_options['std']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcbaker I need some help here with Mypy type annotations. How do I express the idea that I want to delete the std option both from the host compiler and from the overrides, that special flag being handled already beginning at line 638?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcbaker How should I handle the above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless someone can come up with a better solution soon, disabling mypy for that line is fine.

jpakkane added a commit that referenced this pull request Mar 28, 2021
@jpakkane jpakkane removed this from the 0.57.2 milestone Mar 28, 2021
@jpakkane
Copy link
Member

Merged as #8596 so closing.

@jpakkane jpakkane closed this Mar 28, 2021
@obilaniu obilaniu deleted the cuda-multistd branch March 29, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combining default_options : ['cpp_std=c++2a', 'cuda_std=c++17'] breaks nvcc
3 participants