Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable asan memory leak checks on a Cuda test. #9098

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Disable asan memory leak checks on a Cuda test. #9098

merged 1 commit into from
Aug 11, 2021

Conversation

jpakkane
Copy link
Member

Should fix Arch Cuda CI failure.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #9098 (a6c2632) into master (f9d9cb1) will increase coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9098      +/-   ##
==========================================
+ Coverage   57.03%   58.51%   +1.47%     
==========================================
  Files         188      188              
  Lines       42211    42211              
  Branches     8766     8766              
==========================================
+ Hits        24077    24698     +621     
+ Misses      15908    15224     -684     
- Partials     2226     2289      +63     
Impacted Files Coverage Δ
mesonbuild/scripts/vcstagger.py 87.50% <0.00%> (-4.17%) ⬇️
mesonbuild/compilers/cpp.py 45.56% <0.00%> (+0.23%) ⬆️
mesonbuild/dependencies/base.py 74.85% <0.00%> (+0.29%) ⬆️
mesonbuild/envconfig.py 67.35% <0.00%> (+0.51%) ⬆️
mesonbuild/build.py 71.76% <0.00%> (+0.56%) ⬆️
mesonbuild/backend/ninjabackend.py 64.44% <0.00%> (+0.58%) ⬆️
mesonbuild/mesonlib/universal.py 75.79% <0.00%> (+0.65%) ⬆️
mesonbuild/dependencies/pkgconfig.py 56.76% <0.00%> (+0.66%) ⬆️
mesonbuild/dependencies/detect.py 88.28% <0.00%> (+0.90%) ⬆️
mesonbuild/dependencies/misc.py 33.13% <0.00%> (+0.91%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d9cb1...a6c2632. Read the comment docs.

@eli-schwartz
Copy link
Member

@obilaniu since you've touched the cuda module a lot, perhaps you know why this started to fail to begin with?

@obilaniu
Copy link
Contributor

@eli-schwartz Hard to say! I did touch #8396 concerning the sanitizers, but that was CUDA test case 15. This is test case 16 concerning support for multiple CUDA standards, reported #8523 and fixed in #8527 / #8596.

That was 3 months ago. At the time, I seem to recall the CUDA Arch runner was using GCC 10 and CUDA 11.2; Now I see it is using GCC 11 and CUDA 11.3. Perhaps mixed C++ standards and sanitizers play badly, or the new GCC or CUDA Toolkit expose a problem?

@eli-schwartz
Copy link
Member

When I was trying to figure out why it failed, I tried running multiple cuda test cases locally using meson.py setup builddir. They all produced asan erroring executables, but only one test case actually executes the program in a testsuite.

So it's either a general problem with the cuda toolkit itself, or a problem with all our example program sources. I really don't think it's about any PR specifically.

I was hoping maybe you knew some answer like "yeah, current versions of cuda are just buggy".

@jpakkane jpakkane merged commit 05d36ee into master Aug 11, 2021
@obilaniu
Copy link
Contributor

@eli-schwartz It looks like libcuda does weird things that play poorly with ASAN.

@jpakkane jpakkane deleted the cudamem branch August 11, 2021 23:00
@nirbheek nirbheek modified the milestone: 0.59.4 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants