configurable reserve of machines per size per partition #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should add a fixed amount on top of this value during cluster creation. |
|
Somehow I don't understand what this is doing. Any explanation such that I can understand it? |
|
We've decided to implement this directly in the cloud-api (probably in config file) because this approach has no direct advantage for adopters. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently consumers, like cluster-api, of metal-api actually just check if enough workers for the current request are available. With this approach we will end up with a situation that all workers are allocation in a partition.
But this will prevent further actions like rolling updates of worker nodes or firewalls.
To prevent this a configurable amount of machines must stay as reserved to be able to perform these updates.
The reserved machines are now configurable per size and partition.
But this implementation only performs the configuration of these reservation and does not enforce them. This enforcement is still a responsibility of the caller side.