Introduce size reservations for projects. #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reserving machines of a specific size for projects in the the allocation process. This is feature can be important for the operators to have some spare machines available, e.g. for updating Gardener Seed clusters while preventing regular users to allocate the last machines available in a partition. There are also use-cases where certain customers want to use a certain machine size exclusively, which can also be realized with this approach.
majst01
requested changes
Dec 30, 2023
|
References #134. |
majst01
reviewed
Jan 8, 2024
majst01
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we once discussed this in the past but for some reason we said it's impossible to implement. I can't remember why anymore, so here is a suggestion.
This allows reserving machines of a specific size for projects in the the allocation process.
This feature can be important for the operator to have some spare machines available, e.g. for updating Gardener Seed clusters while preventing regular users to allocate the last machines available in a partition. There are also use-cases where certain customers want to use a certain machine size exclusively, which can also be realized with this approach.
Unfortunately, just like the rack spreading, this algorithm is best-effort only. It can be tricked by heavy parallelization because we do not run the
findMachineCandidatefunction in sync. And of course for the case when allocations were already made before the reservations were added, this is also best-effort only.Possible extensions: