DevContainer QoL change #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsee
force-pushed
the
small-devcontainer-changes
branch
from
ace32ce to
5e0cc37
Compare
jnschaeffer
reviewed
Feb 5, 2024
jnschaeffer
approved these changes
Feb 9, 2024
fishnix
approved these changes
Feb 9, 2024
…We aren't making use of the differences in devcontainer 'forwardPorts
jacobsee
force-pushed
the
small-devcontainer-changes
branch
from
5e0cc37 to
831b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass several ports from this devcontainer compose stack (NATS, Hydra, CRDB...) through to the host using the
portsoption directly in thedocker-compose.ymlfile... but we have been omitting the port used by the governor-api app itself from the compose file and instead forwarded it using thedevcontainer.jsonforwardPortsdefinition.This works seamlessly in VSCode, however,
forwardPortsis unsupported by the devcontainer CLI for anyone using another editor/IDE. The main difference between forwarding a port in the compose file vs. usingforwardPortsis thatforwardPortsis necessary for services that only listen on 127.0.0.1 - however, this service listens on 0.0.0.0, thus there is no functional difference here, so proposing this change for QoL/compatibility reasons.