Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevContainer QoL change #96

Merged
merged 1 commit into from
Feb 10, 2024
Merged

DevContainer QoL change #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}
},
// Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [3001],
// "forwardPorts": [3001],
// Uncomment the next line if you want start specific services in your Docker Compose config.
// "runServices": [],
// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
Expand Down
7 changes: 4 additions & 3 deletions .devcontainer/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: '3.9'
version: "3.9"

volumes:
crdb-data:
Expand All @@ -11,7 +11,6 @@ volumes:
networks:
governor:


services:
devcontainer:
build:
Expand All @@ -20,6 +19,8 @@ services:
depends_on:
- nats
command: sleep infinity
ports:
- "3001:3001"
jacobsee marked this conversation as resolved.
Show resolved Hide resolved
env_file:
- .env
volumes:
Expand Down Expand Up @@ -112,7 +113,7 @@ services:
- nats-init
command:
- -c
- '/etc/nats/nats-server.conf'
- "/etc/nats/nats-server.conf"
- -D
volumes:
- ./nats:/etc/nats
Expand Down