✨ Supported forced reboot of preprovisioning images #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
do-not-merge/work-in-progress
dtantsur
force-pushed
the
reboot-preprov
branch
2 times, most recently
from
aa1da0e
to
33e1c36
Compare
dtantsur
force-pushed
the
reboot-preprov
branch
from
33e1c36
to
8d23977
Compare
Most of them were not testing what they are supposed to test. The exposed errors, for example, were due to a misconfigured Validate mock, not because of actual deployment failures. Clean it up.
Hosts can stay in the "available" state for a long time. If the underlying ramdisk image changes, their state may become invalid. This change allows an operator to request a host reboot that will also act in states where the ramdisk is waiting for something.
dtantsur
force-pushed
the
reboot-preprov
branch
from
8d23977
to
d1e306b
Compare
dtantsur
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
dtantsur
force-pushed
the
reboot-preprov
branch
2 times, most recently
from
25149aa
to
5e82fad
Compare
|
/test-centos-e2e-integration-main |
|
/lgtm |
zaneb
reviewed
Apr 6, 2023
Allows restarting a running inspection on image change. The "force" argument to InspectHardware has been renamed to restartOnFailure to avoid confusion. Change the error handling code to immediately retry aborted inspection.
The only way to do it is to go through cleaning.
dtantsur
force-pushed
the
reboot-preprov
branch
from
5e82fad
to
550497a
Compare
|
/test-centos-e2e-integration-main |
The word "force" is too generic, the new name reflects better what the flag does: restart the process when it previously failed. Power actions are left intact since "force" has a more subtle dual meaning in PowerOff.
metal3-io-bot
added
size/XL
|
/test-centos-e2e-integration-main |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new reboot variant:
This reboot mode works in available, provisioning and inspecting states.
Includes: