Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Supported forced reboot of preprovisioning images #1237

Merged
merged 6 commits into from
Apr 20, 2023

Commits on Mar 24, 2023

  1. Fix ironic Provision() unit tests

    Most of them were not testing what they are supposed to test. The
    exposed errors, for example, were due to a misconfigured Validate
    mock, not because of actual deployment failures. Clean it up.
    dtantsur committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4c6f086 View commit details
    Browse the repository at this point in the history
  2. Add "force" reboot operation flag to reboot preprovisioning images

    Hosts can stay in the "available" state for a long time. If the
    underlying ramdisk image changes, their state may become invalid.
    
    This change allows an operator to request a host reboot that will also
    act in states where the ramdisk is waiting for something.
    dtantsur committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    bdc0fb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Restart inspection when forced reboot is requested

    Allows restarting a running inspection on image change.
    
    The "force" argument to InspectHardware has been renamed to
    restartOnFailure to avoid confusion.
    
    Change the error handling code to immediately retry aborted inspection.
    dtantsur committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6e27a8a View commit details
    Browse the repository at this point in the history
  2. Restart deployment when forced reboot is requested

    The only way to do it is to go through cleaning.
    dtantsur committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    550497a View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Configuration menu
    Copy the full SHA
    115c482 View commit details
    Browse the repository at this point in the history
  2. Consistently rename force in Provisioner to restartOnFailure

    The word "force" is too generic, the new name reflects better what
    the flag does: restart the process when it previously failed.
    
    Power actions are left intact since "force" has a more subtle dual
    meaning in PowerOff.
    dtantsur committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6a0a609 View commit details
    Browse the repository at this point in the history