Merge pull request #1323 from matthewrmshin/fix-t-for-cylc-6

Rephrase cycle time to cycle point

doc/etc/rose-rug-advanced-tutorials-suite-date-time/suite.rc.html

@@ -51,8 +51,8 @@ <h2>suite.rc</h2>
         timeout handler = rose suite-hook --mail --shutdown
         timeout = 4320 # 3 days
 [scheduling]
-    initial cycle time = 2013060100
-    final cycle time   = 2013060300
+    initial cycle point = 2013060100
+    final cycle point   = 2013060300
     [[special tasks]]
         cold-start = startup
     [[dependencies]]

doc/etc/rose-rug-suite-writing-tutorial/suite.rc.html

@@ -50,8 +50,8 @@ <h2>suite.rc</h2>
         timeout handler = rose suite-hook --mail --shutdown
         timeout = 4320 # 3 days
 [scheduling]
-    initial cycle time = 2013060100
-    final cycle time   = 2013060300
+    initial cycle point = 2013060100
+    final cycle point   = 2013060300
     [[special tasks]]
         cold-start = fcm_make_navigate, write_start_position
     [[dependencies]]

doc/rose-rug-advanced-tutorials-broadcast.html

@@ -114,8 +114,8 @@ <h3 class="alwayshidden">Task-based Example Suite</h3>
         timeout handler = rose suite-hook --mail --shutdown
         timeout = 4320 # 3 days
 [scheduling]
-    initial cycle time = 2013010100
-    final cycle time = 2013010500
+    initial cycle point = 2013010100
+    final cycle point = 2013010500
     [[special tasks]]
         cold-start = startup
     [[dependencies]]
@@ -226,7 +226,7 @@ <h3 class="alwayshidden">Cycle Time Extension</h3>
       <p>We should make the suite run a bit longer by increasing <samp>final
       cycle time</samp>:</p>
       <pre class="prettyprint lang-cylc">
-    final cycle time = 2013012500
+    final cycle point = 2013012500
 </pre>
     </div>
 

doc/rose-rug-advanced-tutorials-clock-triggered.html

@@ -127,7 +127,7 @@ <h3 class="alwayshidden">Example suite.rc</h3>
         timeout handler = rose suite-hook --mail --shutdown
         timeout = 4320 # 3 days
 [scheduling]
-    initial cycle time = <span id="cylc-time"></span>
+    initial cycle point = <span id="cylc-time"></span>
     [[dependencies]]
         [[[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23]]]
             graph = bell

doc/rose-rug-quiz.html

@@ -739,8 +739,8 @@ <h2 id="questions">Questions</h2>
           <samp>scheduling</samp> section:</p>
           <pre class="prettyprint lang-cylc">
 [scheduling]
-    initial cycle time = 2014010500
-    final cycle time = 2014010700
+    initial cycle point = 2014010500
+    final cycle point = 2014010700
     [[dependencies]]
         [[[0, 12]]]
             graph = """
@@ -897,8 +897,8 @@ <h2 id="questions">Questions</h2>
                 <td class="noborder">
                   <pre class="prettyprint lang-cylc">
 [scheduling]
-    initial cycle time = 2013060100
-    final cycle time   = 2013060300
+    initial cycle point = 2013060100
+    final cycle point   = 2013060300
 </pre>
                 </td>
               </tr>

doc/rose-rug-suite-writing-tutorial.html

@@ -557,8 +557,8 @@ <h3 class="alwayshidden">suite.rc Content</h3>
       <p>Replace <samp>[scheduling]</samp> with the following lines:</p>
       <pre class="prettyprint lang-cylc">
 [scheduling]
-    initial cycle time = 2013060100
-    final cycle time   = 2013060300
+    initial cycle point = 2013060100
+    final cycle point   = 2013060300
     [[special tasks]]
         cold-start = fcm_make_navigate
     [[dependencies]]

doc/rose-rug-suites.html

@@ -517,8 +517,8 @@ <h3 id="dependencies-cycling">Cycling Dependencies</h3>
       <p>We can make this run as a cycling suite, repeating every 12 hours:</p>
       <pre class="prettyprint lang-cylc">
 [scheduling]
-    initial cycle time = 2013010500  # 00:00, 5/1/2013
-    final cycle time = 2013010600    # 00:00, 6/1/2013
+    initial cycle point = 2013010500  # 00:00, 5/1/2013
+    final cycle point = 2013010600    # 00:00, 6/1/2013
     [[dependencies]]
         [[[0, 12]]]  # run each day at 00:00 and 12:00
             graph = hello_pluto =&gt; hello_eris

etc/rose-rug-brief-tour/suite.rc

@@ -7,8 +7,8 @@
         timeout = 4320 # 3 days
     # End Rose required event hook block
 [scheduling]
-    initial cycle time = 2013010100 # The first cycle of the suite is at 00:00 on Jan 1 2013
-    final cycle time   = 2013010200 # The last cycle of the suite is at 00:00 on Jan 2 2013
+    initial cycle point = 2013010100 # The first cycle of the suite is at 00:00 on Jan 1 2013
+    final cycle point   = 2013010200 # The last cycle of the suite is at 00:00 on Jan 2 2013
     [[special tasks]]
         cold-start = fcm_make # This task is only run at the beginning of the suite
     [[dependencies]]

etc/rose-rug-simple/suite.rc

@@ -6,8 +6,8 @@
         timeout=2 # minutes
 
 [scheduling]
-    initial cycle time=2013010100 # 2013-01-01T00:00:00Z
-    final cycle time=2013010200 # 2013-01-02T00:00:00Z
+    initial cycle point=2013010100 # 2013-01-01T00:00:00Z
+    final cycle point=2013010200 # 2013-01-02T00:00:00Z
     [[dependencies]]
         [[[0, 6, 12, 18]]]
             graph=hello[T-6]=>hello

lib/html/rose-bush/cycles.html

@@ -69,14 +69,14 @@ <h3 id="suite-info-label">Suite Info</h3>
 <i class="icon-play icon-white" title="running"></i></span>
 {% if states.last_activity_time -%}
 <abbr class="livestamp" title=
-"{{states.last_activity_time}}Z">{{states.last_activity_time}}Z</abbr>
+"{{states.last_activity_time}}">{{states.last_activity_time}}</abbr>
 {% endif -%}
 </a></li>
 {% elif states.last_activity_time -%}
 <li><a>
 <i class="icon-stop" title="last active"></i>
 <abbr class="livestamp" title=
-"{{states.last_activity_time}}Z">{{states.last_activity_time}}Z</abbr>
+"{{states.last_activity_time}}">{{states.last_activity_time}}</abbr>
 </a></li>
 {% endif -%}
 </ul>

lib/html/rose-bush/jobs.html

@@ -69,14 +69,14 @@ <h3 id="suite-info-label">Suite Info</h3>
 <i class="icon-play icon-white" title="running"></i></span>
 {% if states.last_activity_time -%}
 <abbr class="livestamp" title=
-"{{states.last_activity_time}}Z">{{states.last_activity_time}}Z</abbr>
+"{{states.last_activity_time}}">{{states.last_activity_time}}</abbr>
 {% endif -%}
 </a></li>
 {% elif states.last_activity_time -%}
 <li><a>
 <i class="icon-stop" title="last active"></i>
 <abbr class="livestamp" title=
-"{{states.last_activity_time}}Z">{{states.last_activity_time}}Z</abbr>
+"{{states.last_activity_time}}">{{states.last_activity_time}}</abbr>
 </a></li>
 {% endif -%}
 </ul>
@@ -379,17 +379,17 @@ <h3 id="suite-info-label">Suite Info</h3>
 <div class="span4 text-right"><!-- entry: time -->
 <small>
 <i class="icon-info-sign" title="Submitted"></i> <abbr class="t_submit livestamp"
-title="{{entry.events[0]}}Z">{{entry.events[0]}}Z</abbr>
+title="{{entry.events[0]}}">{{entry.events[0]}}</abbr>
 <!-- entry: submit time -->
 <!-- entry: init time -->
 {% if entry.events[1] -%}
 <i class="icon-play" title="Started"></i> <abbr class="t_init"
-title="{{entry.events[1]}}Z">{{entry.events[1]}}Z</abbr>
+title="{{entry.events[1]}}">{{entry.events[1]}}</abbr>
 {% endif -%}
 <!-- entry: exit time -->
 {% if entry.events[2] -%}
 <i class="icon-stop" title="Exited"></i> <abbr class="t_exit"
-title="{{entry.events[2]}}Z">{{entry.events[2]}}Z</abbr>
+title="{{entry.events[2]}}">{{entry.events[2]}}</abbr>
 {% endif -%}
 <!-- entry: exit time -->
 </small>

lib/python/rose/date.py

@@ -118,6 +118,8 @@ def date_format(self, print_format, time_point=None):
                       Otherwise, use current date time.
 
         """
+        if print_format is None:
+            return str(time_point)
         if "%" in print_format:
             try:
                 return time_point.strftime(print_format)

lib/python/rose/suite_engine_proc.py

@@ -197,15 +197,23 @@ class SuiteStillRunningError(Exception):
     """An exception raised when a suite is still running."""
 
     FMT_HEAD = "Suite \"%(suite_name)s\" may still be running.\n"
-    FMT_BODY = "Host \"%(host)s\" has %(reason_key)s:\n    %(reason_value)s\n"
     FMT_TAIL = "Try \"rose suite-shutdown --name=%(suite_name)s\" first?"
-
+    FMT_BODY1 = "Host \"%(host)s\" has %(reason_key)s:\n"
+    FMT_BODY2 = "    %(reason_value)s\n"
 
     def __str__(self):
         suite_name, reasons = self.args
         ret = self.FMT_HEAD % {"suite_name": suite_name}
+        host = None
+        reason_key = None
         for reason in reasons:
-            ret += self.FMT_BODY % dict(reason)
+            reason_dict = dict(reason)
+            if (reason_dict["host"] != host or
+                    reason_dict["reason_key"] != reason_key):
+                ret += self.FMT_BODY1 % reason_dict
+                host = reason_dict["host"]
+                reason_key = reason_dict["reason_key"]
+            ret += self.FMT_BODY2 % reason_dict
         ret += self.FMT_TAIL % {"suite_name": suite_name}
         return ret
 

lib/python/rose/suite_engine_procs/cylc.py

@@ -650,15 +650,18 @@ def is_suite_registered(self, suite_name):
         return self.popen.run("cylc", "get-directory", suite_name)[0] == 0
 
     def is_suite_running(self, user_name, suite_name, hosts=None):
-        """Return the port file path if it looks like suite is running.
+        """Return the reasons if it looks like suite is running.
 
-        If pgrep "cylc-{run,restart} suite_name",
-        return (host, "process", pid).
+        return [
+            {
+                "host": host,
+                "reason_key": reason_key,
+                "reason_value": reason_value
+            },
+            # ...
+        ]
 
-        If port file exists,
-        return (host, "port-file", "/path/to/.cylc/ports/suite_name").
-
-        Return () otherwise.
+        If not running, return an empty list.
 
         """
         if not hosts:
@@ -671,11 +674,15 @@ def is_suite_running(self, user_name, suite_name, hosts=None):
                  "python.*cylc-(run|restart).*\\<" + suite_name + "\\>"]
         ret_code, out, _ = self.popen.run(*pgrep)
         if ret_code == 0:
+            proc_reasons = []
             for line in out.splitlines():
                 if suite_name in line.split():
-                    return [{"host": "localhost",
-                             "reason_key": self.REASON_KEY_PROC,
-                             "reason_value": line}]
+                    proc_reasons.append({
+                        "host": "localhost",
+                        "reason_key": self.REASON_KEY_PROC,
+                        "reason_value": line})
+            if proc_reasons:
+                return proc_reasons
 
         # remote hosts pgrep and ls port file
         host_proc_dict = {}
@@ -720,7 +727,6 @@ def is_suite_running(self, user_name, suite_name, hosts=None):
                                         "host": host,
                                         "reason_key": self.REASON_KEY_FILE,
                                         "reason_value": line})
-                        break
             if host_proc_dict:
                 sleep(0.1)
 

t/rose-suite-clean/01-running.t

@@ -32,15 +32,17 @@ NAME=$(basename $SUITE_RUN_DIR)
 # Install suite, and prove that directories are created
 rose suite-run --debug -q \
     -C $TEST_SOURCE_DIR/$TEST_KEY_BASE --name=$NAME --no-gcontrol
-SUITE_PROC=$(pgrep -u$USER -fl "python.*cylc-run.*\\<$NAME\\>")
 ls -ld $HOME/cylc-run/$NAME 1>/dev/null
+poll ! test -e $SUITE_RUN_DIR/log/job/my_task_1.2013010100.1
+SUITE_PROC=$(pgrep -u$USER -fl "python.*cylc-run.*\\<$NAME\\>" \
+    | awk '{print "[FAIL]     " $0}')
 #-------------------------------------------------------------------------------
 TEST_KEY=$TEST_KEY_BASE-running
 run_fail "$TEST_KEY" rose suite-clean -y $NAME
 file_cmp "$TEST_KEY.err" "$TEST_KEY.err" <<__ERR__
 [FAIL] Suite "$NAME" may still be running.
 [FAIL] Host "localhost" has process:
-[FAIL]     $SUITE_PROC
+$SUITE_PROC
 [FAIL] Try "rose suite-shutdown --name=$NAME" first?
 __ERR__
 if [[ ! -d $HOME/cylc-run/$NAME ]]; then
@@ -52,7 +54,7 @@ run_fail "$TEST_KEY" rose suite-clean -y -n $NAME
 file_cmp "$TEST_KEY.err" "$TEST_KEY.err" <<__ERR__
 [FAIL] Suite "$NAME" may still be running.
 [FAIL] Host "localhost" has process:
-[FAIL]     $SUITE_PROC
+$SUITE_PROC
 [FAIL] Try "rose suite-shutdown --name=$NAME" first?
 __ERR__
 if [[ ! -d $HOME/cylc-run/$NAME ]]; then

t/rose-suite-log/01-update-cycle/suite.rc

@@ -5,8 +5,8 @@
         timeout handler = "rose suite-hook --shutdown"
         timeout = 1
 [scheduling]
-    initial cycle time = 2013010100
-    final cycle time   = 2013010200
+    initial cycle point = 2013010100
+    final cycle point   = 2013010200
     [[dependencies]]
         [[[ 0, 12 ]]]
             graph = """

t/rose-suite-log/02-update-force/suite.rc

@@ -5,8 +5,8 @@
         timeout handler = "rose suite-hook --shutdown"
         timeout = 1
 [scheduling]
-    initial cycle time = 2013010100
-    final cycle time   = 2013010200
+    initial cycle point = 2013010100
+    final cycle point   = 2013010200
     [[dependencies]]
         [[[ 0, 12 ]]]
             graph = """

t/rose-suite-run/00-run-basic.t

@@ -40,16 +40,14 @@ NAME=$(basename $SUITE_RUN_DIR)
 run_pass "$TEST_KEY" \
     rose suite-run -C $TEST_SOURCE_DIR/$TEST_KEY_BASE --name=$NAME --no-gcontrol
 HOST=$(<$SUITE_RUN_DIR/log/rose-suite-run.host)
-TIMEOUT=$(($(date +%s) + 60)) # wait 1 minute
-while [[ ! -e $HOME/.cylc/ports/$NAME ]] && (($(date +%s) < TIMEOUT)); do
-    sleep 1
-done
+poll ! test -e $SUITE_RUN_DIR/log/job/my_task_1.2013010100.1
 if [[ $HOST == 'localhost' ]]; then
     SUITE_PROC=$(pgrep -u$USER -fl "python.*cylc-run.*\\<$NAME\\>")
 else
     CMD_PREFIX="ssh -oBatchMode=yes $HOST"
     SUITE_PROC=$($CMD_PREFIX "pgrep -u\$USER -fl 'python.*cylc-run.*\\<$NAME\\>'")
 fi
+SUITE_PROC=$(awk '{print "[FAIL]     " $0}' <<<"$SUITE_PROC")
 #-------------------------------------------------------------------------------
 # "rose suite-run" should not work while suite is running.
 # except --reload mode.
@@ -60,7 +58,7 @@ for OPTION in -i -l '' --restart; do
     file_cmp "$TEST_KEY.err" "$TEST_KEY.err" <<__ERR__
 [FAIL] Suite "$NAME" may still be running.
 [FAIL] Host "${HOST:-localhost}" has process:
-[FAIL]     $SUITE_PROC
+$SUITE_PROC
 [FAIL] Try "rose suite-shutdown --name=$NAME" first?
 __ERR__
 done

t/rose-suite-run/00-run-basic/suite.rc

@@ -5,8 +5,8 @@
         timeout handler=rose suite-hook --shutdown
         timeout=2
 [scheduling]
-    initial cycle time=2013010100
-    final cycle time=2013010212
+    initial cycle point=2013010100
+    final cycle point=2013010212
     [[dependencies]]
         [[[ 0, 12 ]]]
             graph=my_task_1

t/rose-suite-run/02-install/suite.rc

@@ -5,8 +5,8 @@
         timeout handler = "rose suite-hook --shutdown"
         timeout = 2
 [scheduling]
-    initial cycle time = 2013010100
-    final cycle time   = 2013010200
+    initial cycle point = 2013010100
+    final cycle point   = 2013010200
     [[dependencies]]
         [[[ 0, 12 ]]]
             graph = """

t/rose-suite-run/05-log/suite.rc

@@ -5,8 +5,8 @@
         timeout handler = "rose suite-hook --shutdown"
         timeout = 1
 [scheduling]
-    initial cycle time = 2013010100
-    final cycle time = 2012010100 # deliberate, so no task is run
+    initial cycle point = 2013010100
+    final cycle point = 2012010100 # deliberate, so no task is run
     [[dependencies]]
         [[[0]]]
             graph = """