Rephrase cycle time to cycle point #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
changed the title
Fix tests for cylc 6. When checking whether a suite is running or not, allow reasons to contain all lines of the `pgrep` command.
Simply return `TimePoint` object if format string is `None`.
|
@benfitzpatrick please review. |
| if "%" in print_format: | ||
| if print_format is None: | ||
| return str(time_point) | ||
| if print_format and "%" in print_format: |
There was a problem hiding this comment.
First part of the if isn't necessary here, I think.
We can now assume that cylc stores date time correctly.
|
Fixed unnecessary I have also fixed some unnecessary Z syntax in the Rose Bush templates. This is to assume that cylc is now storing date time with time zone information. |
This is always supposed to be true now. |
benfitzpatrick
added a commit
that referenced
this pull request
Aug 8, 2014
Rephrase cycle time to cycle point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rephrase cycle time to cycle point for cylc 6.
Improve reporting of running cylc processes.
Now that cylc/cylc-flow#996 is closed, we need this for Rose to work correctly.