Prep pmforest for mpn.scorecard and package release #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove collated scripts (not needed)
kyleam
approved these changes
Sep 11, 2023
pkgr.yml
Outdated
| @@ -11,7 +11,7 @@ Packages: | |||
|
|
|||
| Repos: | |||
| - CRAN: https://cran.rstudio.com # used for most things | |||
| - MPN: https://mpn.metworx.com/snapshots/stable/2022-02-11 # used for pmtables and mrgval | |||
| - MPN: https://mpn.metworx.com/snapshots/stable/2023-08-24 # used for pmtables and mrgval | |||
There was a problem hiding this comment.
Given the mpn.scorecard transition, this cleanup series could also 1) remove mrgval* from DESCRIPTION, 2) removed the mention here, 3) delete inst/validation, and 4) remove test IDs from the test names.
There was a problem hiding this comment.
I just confirmed that we still need MPN for pmtables and yspec, but made the other suggested changes and improved the corresponding comment
There was a problem hiding this comment.
I just confirmed that we still need
MPNforpmtablesandyspec, but made the other suggested changes [...]
I didn't suggest that you remove this URL, just that you remove the mention of mrgval here.
- no longer part of our validation plan
- determined that MPN was still being used for some imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before releasing the next version of
pmforest, I wanted to ensure it would A) receive a good score withmpn.scorecard, and B) tidy up some unnecessary things we discovered while testing this package withmpn.scorecardpreviously