Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep pmforest for mpn.scorecard and package release #33

Merged
merged 8 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Authors@R:
role = "aut",
email = "annanev@umich.edu"))
License: MIT + file LICENSE
URL: https://metrumresearchgroup.github.io/pmforest, https://github.com/metrumresearchgroup/pmforest
BugReports: https://github.com/metrumresearchgroup/pmforest/issues
Imports:
assertthat,
dplyr,
Expand Down Expand Up @@ -48,13 +50,4 @@ Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
VignetteBuilder: knitr
Collate:
'classicforest.R'
'table-plot.R'
'forest-constructor.R'
'AAAA.R'
'helpers-for-tests.R'
'plot-forest.R'
'summarize-data.R'
'utils-null.R'
'utils-pipe.R'

3 changes: 0 additions & 3 deletions R/AAAA.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
#' @importFrom stats median quantile
#' @importFrom RColorBrewer brewer.pal
#'
#' @include forest-constructor.R
#' @include table-plot.R
#' @include classicforest.R
#'
NULL

Expand Down
14 changes: 0 additions & 14 deletions R/utils-null.R

This file was deleted.

2 changes: 1 addition & 1 deletion pkgr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Packages:

Repos:
- CRAN: https://cran.rstudio.com # used for most things
- MPN: https://mpn.metworx.com/snapshots/stable/2022-02-11 # used for pmtables and mrgval
- MPN: https://mpn.metworx.com/snapshots/stable/2023-08-24 # used for pmtables and mrgval
Copy link
Collaborator

@kyleam kyleam Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the mpn.scorecard transition, this cleanup series could also 1) remove mrgval* from DESCRIPTION, 2) removed the mention here, 3) delete inst/validation, and 4) remove test IDs from the test names.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed that we still need MPN for pmtables and yspec, but made the other suggested changes and improved the corresponding comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed that we still need MPN for pmtables and yspec, but made the other suggested changes [...]

I didn't suggest that you remove this URL, just that you remove the mention of mrgval here.


Lockfile:
Type: renv
Expand Down
8 changes: 8 additions & 0 deletions tests/testthat/_snaps/base-plot/axis-labels-and-captions.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions tests/testthat/_snaps/base-plot/base-plot.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions tests/testthat/_snaps/base-plot/ci-table-mean.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions tests/testthat/_snaps/base-plot/ci-table-median.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading