Skip to content

Commit

Permalink
build: fix case in lib names
Browse files Browse the repository at this point in the history
ninja on Windows chokes if libs are named .Lib (Capital L)

PR-URL: nodejs/node#12522
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
refack authored and andrew749 committed Jul 19, 2017
1 parent 10026e6 commit b043cf3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@
'conditions': [
[ 'OS=="win"', {
'link_settings': {
'libraries': [ '-lAdvAPI32.Lib', '-lUser32.lib' ],
'libraries': [ '-lAdvAPI32.lib', '-lUser32.lib' ],
},
}],
],
Expand Down Expand Up @@ -518,7 +518,7 @@
'conditions': [
[ 'OS=="win"', {
'link_settings': {
'libraries': [ '-lAdvAPI32.Lib', '-lUser32.lib' ],
'libraries': [ '-lAdvAPI32.lib', '-lUser32.lib' ],
},
}],
],
Expand Down

0 comments on commit b043cf3

Please sign in to comment.