build, icu: fix case in lib names #12522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninja on Windows chokes if libs are named .Lib (Capital L)
nodejs-github-bot
added
i18n-api
mscdex
added
build
richardlau
approved these changes
Apr 19, 2017
|
ping @srl295 |
gibfahn
approved these changes
Apr 21, 2017
refack
added a commit
that referenced
this pull request
Apr 21, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Post land CI: https://ci.nodejs.org/job/node-test-commit/9306/ |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in v6.x, LMK if it shouldn't have. |
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: #12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
ninja on Windows chokes if libs are named .Lib (Capital L) PR-URL: nodejs/node#12522 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ninja on Windows chokes if libs are named .Lib (Capital L)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build,intl