fix: test with APIGatewayProxy #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e64cb0b.
|
Which test is that precisely? There seem to be a flaky test which would explain. |
|
yes that's the one |
|
So it "passed" because it's detected as flaky. |
|
I have split the test in two different test files. And that seems to help. 🤷🏻♂️ |
sdelamo
force-pushed
the
fix-test-runtime-api-loop
branch
from
2da8b24 to
7b5c1c7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
ive figured it out. the failure is caused by micronaut-projects/micronaut-core#7635 . i will fix it in core |
yawkat
added a commit
to micronaut-projects/micronaut-core
that referenced
this pull request
Sep 6, 2022
Move some converters from NettyConverters into a new converter registrar that does not require further dependencies from the application context. This allows the registrar to be loaded into the default conversion service with no app context present. This is a workaround for #7948, and fixes micronaut-projects/micronaut-aws#1452 .
sdelamo
pushed a commit
to micronaut-projects/micronaut-core
that referenced
this pull request
Sep 6, 2022
* Move some netty converters to SPI Move some converters from NettyConverters into a new converter registrar that does not require further dependencies from the application context. This allows the registrar to be loaded into the default conversion service with no app context present. This is a workaround for #7948, and fixes micronaut-projects/micronaut-aws#1452 . * move httpdata converters as well * unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to dowgrade to 3.5.5
because the Body string received with
3.6.2here:is :
PooledSlicedByteBuf(ridx: 0, widx: 156, cap: 156/156, unwrapped: PooledUnsafeDirectByteBuf(ridx: 364, widx: 364, cap: 2048))@yawkat any idea what could be the culprit?