Reset shared ConversionService instance state on context restart

[dstepanov]

Fixes micronaut-projects/micronaut-serialization#237

[graemerocher]

can you fix the test failures? Seem tests relied on this previously present shared state.

[dstepanov]

Targeting 3.6

[yawkat]

if this reliably fails now, maybe your change caused the allocator class that reads the system property to load before the config is applied. this needs to be fixed

[yawkat]

can you explain why this change is necessary and related to the serialization issue? what kind of state is the shared conversion context carrying that needs to be reset?

[dstepanov]

We register convertors into the static instance which is shared across bean contexts. The problem arises when the convertor was registered with an instance of the bean context, that convertor will fail when accessed after the bean context is destroyed.

[yawkat]

ah, makes sense. a bit weird though to register to a shared conversion context from a bean context that isnt shared...

[dstepanov]

We should change it probably in 4.0. Shared ConversionService to allow contribute converters only using service loaded and another bean context instance ConversionService delegating to the static one. I have something like this in Micronaut Data.

[dstepanov]

It looks like custom ForkAndJoin still deadlocks

[yawkat]

is it called in a static initializer? in that case you cant use multithreading at all without risking deadlocks

[dstepanov]

Yep, going to remove forking

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

81.0% Coverage
0.0% Duplication

[graemerocher]

Still failing on Java 17 :(

[dstepanov]

I did restart and it passed :-/