Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override with 404 when returning response inside CompletableFuture #10501

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Feb 16, 2024

Fixes #10419

@yawkat yawkat added the type: bug Something isn't working label Feb 16, 2024
@yawkat yawkat added this to the 4.4.0 milestone Feb 16, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Feb 16, 2024

Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Checked, and Servlet passes too 😻

@sdelamo sdelamo merged commit 3d0f920 into 4.4.x Feb 16, 2024
15 checks passed
@sdelamo sdelamo deleted the empty-response-future branch February 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants